Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46373 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 2212 invoked from network); 9 Dec 2009 18:37:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Dec 2009 18:37:09 -0000 Authentication-Results: pb1.pair.com header.from=saramg@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=saramg@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.221 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: saramg@gmail.com X-Host-Fingerprint: 209.85.220.221 mail-fx0-f221.google.com Received: from [209.85.220.221] ([209.85.220.221:36083] helo=mail-fx0-f221.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 09/B9-55877-35EEF1B4 for ; Wed, 09 Dec 2009 13:37:08 -0500 Received: by fxm21 with SMTP id 21so6924100fxm.1 for ; Wed, 09 Dec 2009 10:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=OXGfb8OUqZkq8NBPFsn5OpLFZIsVN+iEo9OkvQcvjnE=; b=FcVKcR7eWyNeEYaonIyMrWoJqA4ZeZFPn0s1jciV2koSpZEketnUEXkzg0dz5s52+N yujve87gvdKkf94pKbikprvc6qykt80T+ollnXKhTEIkdlomD6fAWaUzO/DzWfz8FGVc sLDukLGt0Gq1Tp/+xcUSmDEitlxY3zORMHXH4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=evpLuFEHtONPQB4R8bo/c+jTfr6vvXq3ZzxyFh/Z6dyhLnXvx98AnBoHV2kMbbnB5v UMSM5hgHVnrOuZFlAlQYetR2REtbdjFzoRGrqtX3RU4jip7z46sj69DnZQC6bqJpRLCN GkVSrNgeKFq0pfPjyyLw8ImOXHK8bIhXW0nVg= MIME-Version: 1.0 Sender: saramg@gmail.com Received: by 10.223.4.144 with SMTP id 16mr2088894far.36.1260383824881; Wed, 09 Dec 2009 10:37:04 -0800 (PST) Date: Wed, 9 Dec 2009 10:37:04 -0800 X-Google-Sender-Auth: 7cd941417a5c5275 Message-ID: <3cf130880912091037p761ce8d0sae979bb670dcd4b3@mail.gmail.com> To: PHP Internals , felipe@php.net Content-Type: text/plain; charset=UTF-8 Subject: Breaking APIs for no good reason is a bad thing. (tm) From: pollita@php.net (Sara Golemon) Now, I'll take some blame here for not being involved over the past couple years and having not noticed this inanity sooner, but could someone explain this cluster-f? http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/Zend/zend_API.h?r1=268281&r2=269153 This breaks the existing module API because any rational extension developer has been putting 'static' in front of ZEND_BEGIN_ARG_INFO_EX() _where appropriate_ for the better part of a decade and it does ABSOLUTELY NOTHING more than the very /minor/ optimization of cleaning up the symbol space of poorly written modules. Worse, it breaks the ability of extension developers to keep arg_info structures next to the functions they belong to while still keeping those functions in separate files. Someone give me a good reason not to revert this. -Sara