Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46259
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.44 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=fCnfXL2yRxCYZXebw3cou3IVfXP793SwPV0UIqIIF2fuoL5ZWJ4l6wzuh3dNDJDsQx
         W+EqhMIw+KMkNhTt/IQkqnDvGavhy8AF06N7mFW5zBG4bvvOmXIIydCETJtTA7S9aopu
         xJ9189iKkPqbNGiwwLuY5rY3sPvq0pvrkj5P8=
MIME-Version: 1.0
In-Reply-To: <1259669142.2291.9.camel@guybrush>
References: <b65d742b0911300532g1b60034cn30b56c10d88e7cde@mail.gmail.com>
	 <1259669142.2291.9.camel@guybrush>
Date: Tue, 1 Dec 2009 18:16:34 +0530
Message-ID: <b65d742b0912010446m61cf8877n2f3934600e8a5edd@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] - Improving multi-threaded performance by 
	propagating TSRMLS_C
From: yoarvi@gmail.com (Arvind Srinivasan)

hi johannes,


> I'm not too happy about hiding the TSRM macro with another macro as it
> makes reading the code harder. When writing code I want to spot easily
> whether my function needs TSRM or not.
>
> When adding such a macro that should be done for making the code better
> readable, not worse.
>

I'm currently working on getting rid of this change and instead
explicitly passing TSRMLS_C.

>> where
>> +#define TSRMLS_DC1 =A0 TSRMLS_D,
>> +#define TSRMLS_CC1 =A0 TSRMLS_C,
>
> Are there more cases of this? - If zend_get_parameters is the only case


multi_convert_to_long_ex
multi_convert_to_double_ex
multi_convert_to_string_ex

are the other use cases of this.

thanks,
arvi