Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46252
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.222.176 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=FxgNHUJ8HxBFQsiTp8hbkFLt/Hr58R0S5wie3Ln4SREstmztj7rnmVYKqMFUJF8ECS
         3UsEiUdIHFL42KjvvNGIwHymTd71blGBDbddlJvkQZKNqeaX0fzmac+Vc981h0SlVuOw
         xwoHn5Lu7tIR1CPIKgTc6sZY+EhFO2dCZuxWI=
MIME-Version: 1.0
In-Reply-To: <fe05d1540911300626n67754b14h17d42e1a558b2ce7@mail.gmail.com>
References: <b65d742b0911300532g1b60034cn30b56c10d88e7cde@mail.gmail.com>
	 <fe05d1540911300626n67754b14h17d42e1a558b2ce7@mail.gmail.com>
Date: Mon, 30 Nov 2009 21:51:38 +0530
Message-ID: <b65d742b0911300821u13fe9a12s9a79d318d5e3f2c4@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH] - Improving multi-threaded performance by 
	propagating TSRMLS_C
From: yoarvi@gmail.com (Arvind Srinivasan)

Hi Pierre,


> slow (as you noticed). However it can't be done in 5.3 as it will
> break the ABI.
>

I noticed that a recent fix (http://bugs.php.net/bug.php?id=49936)
added TSRMLS_DC to an API in 5.3.
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/main/streams/php_stream_context.h?r1=290796&r2=290795&pathrev=290796

Wouldn't that need to be reverted as it breaks the ABI?

> About the patch itself, as it will break ABI anyway, I would go wit
> the solution 1) only. That's cleaner and consistent with what we
> usually do.
>

Ok, I'll get rid of the _ prefix diffs. Do my approaches (3) (4) for
varargs look ok?

Thanks for your review.

arvi