Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46193 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45164 invoked from network); 26 Nov 2009 00:43:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Nov 2009 00:43:21 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 212.25.124.185 il-mr1.zend.com Received: from [212.25.124.185] ([212.25.124.185:45660] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 11/91-45906-72FCD0B4 for ; Wed, 25 Nov 2009 19:43:20 -0500 Received: from us-gw1.zend.com (unknown [192.168.16.5]) by il-mr1.zend.com (Postfix) with ESMTP id 3A307504C9; Thu, 26 Nov 2009 02:29:57 +0200 (IST) Received: from [192.168.16.93] ([192.168.16.93]) by us-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 25 Nov 2009 16:43:14 -0800 Message-ID: <4B0DCF21.7070201@zend.com> Date: Wed, 25 Nov 2009 16:43:13 -0800 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Arpad Ray CC: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Nov 2009 00:43:14.0283 (UTC) FILETIME=[6FDF2BB0:01CA6E31] Subject: Re: [PHP-DEV] [PATCH] default session serialization From: stas@zend.com (Stanislav Malyshev) Hi! > Attached is a patch (against HEAD) which adapts the default ("php") > session serializer to serialize the whole array using php_var_serialize > instead of calling it once per element. > > This simplifies the serialization code, and allows unicode session keys, > or even ascii keys containing the pipe character. I think it makes sense. One note: your code allows numeric session keys, previously not allowed. Not sure if it's important. > However it would be a significant BC break, as old serialized session > records would be unreadable after upgrading. We could mitigate this by > providing a script to convert old session files. If it would be a problem, we could always keep an old one as "php_old" for a while for those who need it, just not make it the default. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com