Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46176
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain prohost.org from 209.85.210.192 cause and error)
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <4B0C555E.4030004@cdatazone.org>
Date: Tue, 24 Nov 2009 17:01:14 -0500
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>,
 PHP Developers Mailing List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <186A2EB4-2B2D-457F-AC7D-E0139EC4AD8E@prohost.org>
References: <4B0C177A.6020500@cdatazone.org> <4B0C1A7C.9030306@lerdorf.com> <4B0C555E.4030004@cdatazone.org>
To: Rob Richards <rrichards@cdatazone.org>
Subject: Re: [PHP-DEV] openssl supported algorithms
From: ilia@prohost.org (Ilia Alshanetsky)

Heh, I think given that we have 5.3 out there (with the code) there is =
little reason to introduce new features into a bug fix release which is =
5.2.

On 2009-11-24, at 4:51 PM, Rob Richards wrote:

> If I had only checked... Appears its been in trunk (and 5_3) for over =
2 years now :)
>=20
> Rob
>=20
> Rasmus Lerdorf wrote:
>> Seems like a no-brainer for 5.3 and trunk.  You will have to discuss
>> with Ilia for 5.2.  It seems a bit late in the game for that branch =
to
>> get this.
>>=20
>> -Rasmus
>>=20
>> Rob Richards wrote:
>> =20
>>> The openssl extension is way to restrictive in the algorithms it
>>> supports, i.e. no support for SHA265 which is starting to become the
>>> standard algo to use, etc.. Rather than having to always add more
>>> constants and additional logic for any new algorithms, I'd like to
>>> change the sign and verify functions to not only accept the current
>>> integers, but also a string so the EVP_get_digestbyname function can =
be
>>> used.
>>>=20
>>> So while still supporting something list:
>>> openssl_sign($data, $signature, $priv_key_id, OPENSSL_ALGO_SHA1)
>>>=20
>>> It can also be called using:
>>> openssl_sign($data, $signature, $priv_key_id, "SHA1")
>>> openssl_sign($data, $signature, $priv_key_id, "SHA256")
>>>=20
>>> Attached is a patch to illustrate the change made to the PHP_5_2 =
branch
>>> (only to the sign function but same change would be made to verify =
as
>>> well).
>>> I'd really like to be able to support the string based algorithm =
rather
>>> than always having to add constants just for the added flexibility =
but
>>> in any case we really need to add support for more than what we have
>>> now. Personally I'd also like to see this in 5.2.12 but know that =
might
>>> be pushing it.
>>>=20
>>> Rob
>>>=20
>>>=20
>>>   =20
>>=20
>>=20
>> =20
>=20
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20