Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46172 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94598 invoked from network); 24 Nov 2009 13:58:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Nov 2009 13:58:01 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.211.197 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.211.197 mail-yw0-f197.google.com Received: from [209.85.211.197] ([209.85.211.197:62365] helo=mail-yw0-f197.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 22/1B-29930-866EB0B4 for ; Tue, 24 Nov 2009 08:58:01 -0500 Received: by ywh35 with SMTP id 35so6023563ywh.7 for ; Tue, 24 Nov 2009 05:57:58 -0800 (PST) Received: by 10.101.159.15 with SMTP id l15mr4343551ano.159.1259071078329; Tue, 24 Nov 2009 05:57:58 -0800 (PST) Received: from ?192.168.200.22? (c-98-234-184-167.hsd1.ca.comcast.net [98.234.184.167]) by mx.google.com with ESMTPS id 7sm2387407yxg.32.2009.11.24.05.57.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 24 Nov 2009 05:57:56 -0800 (PST) Message-ID: <4B0BE662.10602@lerdorf.com> Date: Tue, 24 Nov 2009 05:57:54 -0800 User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Michael Maclean CC: internals@lists.php.net References: <4B0BE3B5.1030606@no-surprises.co.uk> In-Reply-To: <4B0BE3B5.1030606@no-surprises.co.uk> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c From: rasmus@lerdorf.com (Rasmus Lerdorf) Michael Maclean wrote: > Hi, > Gwynne pointed me at the clang static analyser earlier on today, and so > I've run it against current PHP_5_3. In the course of messing with it, > it noticed a potential null dereference in ext/ftp - I've attached a > one-liner to fix it. Thanks, committed.