Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46074
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.227 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:date:x-google-sender-auth:message-id:subject
         :from:to:content-type;
        b=EODJcGi1leQZEoAhW99TywWkCo2t1uqcqYs89ATlFIpllrxGduVTAkAOE50OrDRmAF
         7g0NER2A03rhWwlRcYUayVXOJ6eqwpT+2YuXAv4avWPzohmDD3Tcw48wauIXNclN4y3C
         ZqBlnGp96oasBtiUWCQ4H7TERNjiNf7RRrYGM=
MIME-Version: 1.0
Sender: mikko.koppanen@gmail.com
Date: Tue, 17 Nov 2009 18:34:06 +0000
Message-ID: <8cf711460911171034p2565efd5p20874e4841575315@mail.gmail.com>
To: PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Ability to intercept errors even if set_error_handler has been called
From: mkoppanen@php.net (Mikko Koppanen)

Hello,

In monitoring type extensions such as Xdebug, APM etc it is common to
override zend_error_cb with a custom callback to intercept errors.
This however has a drawback: if user calls set_error_handler the
zend_error_cb does not get called at all for errors that can be
handled in userspace. There are a few approaches to solving this
(namely disabling set_error_handler or overriding set_error_handler)
but neither of them really seems like a good solution.

I made a simple patch that adds always_invoke_error_cb which allows
invoking the zend_error_cb in these cases (it needs to be set on
explicitly in an extension). error_handled_by_user setting allows
extensions to stop propagating the event if it's handled by user's
handler.

The patch is very simple and probably breaks horribly with some edge
cases. Ideas? Feedback?

http://pastie.org/702900

-- 
Mikko Koppanen