Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46043
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.158 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=eiJ4g6kmAF33kHJX2x6jww9NbcTvXarwsuisPjgJVbKRPrvvJjdhttzeWPnbmeSXm3
         NwtRChL1Q2QTMojLmeQWJJKY9Mt48Kpa1NnW6dYJQrYHOvxSmNI11fa4mliHSCnCzMWY
         fRjiZ53EgdedxMub+Tx5ezadHGAbzpm8tRzHo=
MIME-Version: 1.0
In-Reply-To: <16bf97b10911130226x25c16bd9xbe21d33f3937e7e3@mail.gmail.com>
References: <16bf97b10911130226x25c16bd9xbe21d33f3937e7e3@mail.gmail.com>
Date: Sun, 15 Nov 2009 18:36:34 -0200
Message-ID: <46ccd1ab0911151236l5bb7020fma64b1115fafb4419@mail.gmail.com>
To: Pierrick Charron <pierrick@webstart.fr>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=0016e6d7eb6851383204786ed98f
Subject: Re: [PHP-DEV] Patch for bug #49936
From: felipensp@gmail.com (Felipe Pena)

--0016e6d7eb6851383204786ed98f
Content-Type: text/plain; charset=UTF-8

Hi Pierrick,

2009/11/13 Pierrick Charron <pierrick@webstart.fr>

> Hi,
>
> I created a patch for the bug #49936.
>
> The problem was due to the new way to manage references of stream context.
> The patch increase the refcount of the context when it's assigned to a
> stream (in the method php_stream_context_set).
> A zend_list_delete is already called on the context when the stream is
> destroyed to do the opposit.
>
> There is two different version of the patch. The better one (because
> it's not using TSRMLS_FETCH) modify the php_stream_context_set which
> may be used by some of the PECL extensions. And of course the second
> version of the patch use TSRMLS_FETCH to avoid signature modification.
>
> http://www.adoy.net/php/stream-nofetch.diff
> http://www.adoy.net/php/stream-fetch.diff
>
> I also wrote two phpt for this bug :
>
> http://www.adoy.net/php/phpt/bug49936-phpt.tgz
>
> Thanks for feedbacks.
> Pierrick
>
>
>
Committed! Thanks for the patch again!

-- 
Regards,
Felipe Pena

--0016e6d7eb6851383204786ed98f--