Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46036
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.227 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=nbJl1H1h1JQsHXvK9zqNDxrWF3QAn20azGVVRCQ2wSADwPKxytr1Gm4HHcxuG/yTZO
         69Nl5RBQJ84ihp08SWMhFhs8zZcRNn+AlAUXGLbiWyfCjqq3iy77wolEkrqFBF0IAEzv
         qqvWw2Hu9DQuklZVCf9Op15M7z3J21vlx3l8U=
Date: Thu, 12 Nov 2009 13:49:38 -0800
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: internals@lists.php.net
Message-ID: <20091112214938.GA13076@lbasantk3.red.iplanet.com>
References: <20091112185555.GB4294@lbasantk3.red.iplanet.com> <4AFC680F.7050400@lerdorf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AFC680F.7050400@lerdorf.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Subject: Re: [PHP-DEV] open/close calls of include_once/require_once files.
From: basant.kukreja@gmail.com (Basant Kukreja)

On Thu, Nov 12, 2009 at 11:54:55AM -0800, Rasmus Lerdorf wrote:
> A couple of notes.
> 
> You make it sound like this happens on all includes.  It is only
> include_once/require_once that have this problem.  Regular
> include/require do not.
Sorry for making it confusing. I meant only for include_once/require_once
files.

> This has been addressed in APC by overriding the opcode and providing
> our own opcode handler for this case.  See
> http://svn.php.net/viewvc/pecl/apc/trunk/apc_zend.c?view=markup&pathrev=289331
> line 86.
Thanks for the link.


> Having said that, it would be preferable, of course, if we didn't need
> to swap out that code in APC but I am not sure your solution for solving
> this only for absolute path includes is the right way to go here.
I don't think it is possible to avoid calling zend_stream_open for files other
than absolute paths in PHP.

Rationale : Opcode cacher doesn't need to override the op if php engine can
perform the check with ease. Cacher can however override it if included file is
not in file-system.

Regards,
Basant.