Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46028
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
In-Reply-To: <4AFAC12B.7000909@chiaraquartet.net>
Date: Wed, 11 Nov 2009 14:57:40 +0100
Cc: Mikko Koppanen <mkoppanen@php.net>,
 Stanislav Malyshev <stas@zend.com>,
 internals@lists.php.net,
 Christian Schneider <cschneid@cschneid.com>
Content-Transfer-Encoding: 7bit
Message-ID: <E2607969-36CA-47B6-B8E3-FBEE2E9A2A00@pooteeweet.org>
References: <413588E2-8AC8-49F7-B7BF-97BEFB0A71E4@pooteeweet.org> <4AF9A03E.8000207@cschneid.com> <4AF9AE1A.9000005@zend.com> <4AF9C589.3090604@chiaraquartet.net> <4AF9CCEA.1030500@zend.com> <4AFA0449.2030600@chiaraquartet.net> <4AFA0756.4020609@zend.com> <4AFA0A38.7000502@chiaraquartet.net> <8B520687-04D6-4CB3-BB7A-51A62D74489B@pooteeweet.org> <8cf711460911110244m22e2fedag21e294d8d3909037@mail.gmail.com> <65D94139-8A66-4C89-8418-160F5B2A4280@pooteeweet.org> <4AFAC12B.7000909@chiaraquartet.net>
To: Greg Beaver <greg@chiaraquartet.net>
Subject: Re: [PHP-DEV] Re: alternative to the fopen() hack in autoloaders
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 11.11.2009, at 14:50, Greg Beaver wrote:

> Lukas Kahwe Smith wrote:
>>
>> On 11.11.2009, at 11:44, Mikko Koppanen wrote:
>>
>>> On Wed, Nov 11, 2009 at 10:00 AM, Lukas Kahwe Smith

>> so a byte code cache should cache the resolution of the path thereby
>> speeding up the subsequent call to include?
>
> stream_resolve_include_path() as currently constructed could not be
> intercepted, and is actually unable to process an include_path that
> contains streams.  I'm guessing it was written long before PHP 5.3.
> This could be easily fixed by having stream_resolve_include_path call
> zend_resolve_path() instead of doing its own internal calculations.
> With these changes, an opcode cache could easily cache the results.

ok.

> As for your naming concerns, if we were to add an alias called
> is_includable() to stream_resolve_include_path(), that would be much
> clearer:
>
> if (is_includable($file)) {
>    include $file;
> }
>
> The assumption here is that we are simply testing whether the file
> exists and whether php can actually read the file, not whether the  
> file

Well I still maintain that is_includable() could imply for people that  
no error can occur. Just like when calling is_int() means that it  
really is an integer. so I still prefer "exists" or "resolve".

> has syntax errors.  A file with syntax errors is an exceptional
> situation, and should be handled by a clear fatal error, imo.


well the error raised for a syntax error or missing file would not  
change if we go in this direction.

regards,
Lukas Kahwe Smith
mls@pooteeweet.org