Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46003
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=windows-1252; format=flowed; delsp=yes
In-Reply-To: <4AF9B5B8.90104@zend.com>
Date: Tue, 10 Nov 2009 19:57:36 +0100
Cc: Guilherme Blanco <guilhermeblanco@gmail.com>,
 PHP Developers Mailing List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <536BF944-AB9D-4B5F-86CB-B75D3C0D7F63@pooteeweet.org>
References: <413588E2-8AC8-49F7-B7BF-97BEFB0A71E4@pooteeweet.org> <bcb7aa500911100900n7c7c5dbexf5ad369134584c58@mail.gmail.com> <4AF9B5B8.90104@zend.com>
To: Stanislav Malyshev <stas@zend.com>
Subject: Re: [PHP-DEV] alternative to the fopen() hack in autoloaders
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 10.11.2009, at 19:49, Stanislav Malyshev wrote:

> Hi!
>
>>> In order to solve the above issues this RFC proposes the addition =20=

>>> of a new
>>> construct/function for now called =93autoload_include=94 for lack of =
a =20
>>> better
>>> name that largely behaves like the =93include=94 does today with the =
=20
>>> following
>>> differences, that when the include failed because of a missing =20
>>> file no
>>> warning is raised and php null is returned.
>
> Maybe it'd be easier to just add parameter to file_exists that =20
> allows it to use include_path? I think that's at least what ZF is =20
> trying to do with that fopen - it tries to find out if such file =20
> exists in the path and if so - include it.
> I don't think you need to create special language construct for that =20=

> - you can shut off warning with @.


yes that would solve the issue partially. the race condition would =20
still remain, but its admitedly a rare case .. well I guess not so =20
rare if you have a busy site and try to implement some caching for =20
generated files .. then again these kinds of files are rarely loaded =20
via autoload (probably more used for some generated arrays and stuff =20
like that). it would also not solve the imho needless file system =20
operations.

that being said, i brought up adding such a flag to file_exists() a =20
few times before and each attempt has been shot down saying that fopen=20=

() should have never gotten this flag and this portion of the code =20
should not mess with the include path.

regards,
Lukas Kahwe Smith
mls@pooteeweet.org