Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45969
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.213 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=JkqVlIgKIQuc2c/74ksF6yeBnEnwDscUMnCLprlio8fHmRQkE9rh9rCShBDo6nuOao
         1W9zJQb0cLuUP9lv6M4Cn8aaCJwkRLPjEOfky10r2vwmBmPB9n71yAwHKbkzIajnSVTK
         dC00OYkPskaFt/qccr5REJ+SzP0/eSmSlW2fM=
MIME-Version: 1.0
In-Reply-To: <3D00FD9C-488D-4BE0-A17E-48828C24EC60@macvicar.net>
References: <da07b6240911051918t76f32d74s65b05aa94db41951@mail.gmail.com>
	 <3D00FD9C-488D-4BE0-A17E-48828C24EC60@macvicar.net>
Date: Fri, 6 Nov 2009 08:00:07 -0800
Message-ID: <c25f8d340911060800m138b3265jeae04cfbdecbfaaa@mail.gmail.com>
To: Scott MacVicar <scott@macvicar.net>
Cc: daqing <kinch.zhang@gmail.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] typo found in ext/standard/string.c, inside function 
	nl2br, php 5.3.0 svn trunk
From: 0xcafefeed@gmail.com (mm w)

 say CR LF carriage return and line feed, yes those characters could
be trimmed, I think it's a choice to keep the original input you could
redefine a function if your are no happy with it or even add an
optional param to the C function: bool  preserveCRLF, I am not really
convinced by Scott argument 8-)

On Friday, November 6, 2009, Scott MacVicar <scott@macvicar.net> wrote:
> On 6 Nov 2009, at 03:18, daqing wrote:
>
>
> hi, all:
>
> I just found a typo today when I read the source code of function nl2br,
> here is what 'svn diff' produce against the php 5.3.0 svn trunk:
>
> Index: ext/standard/string.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- ext/standard/string.c =C2=A0 =C2=A0 =C2=A0 (revision 290364)
> +++ ext/standard/string.c =C2=A0 =C2=A0 =C2=A0 (working copy)
> @@ -3918,7 +3918,7 @@
>  =C2=A0 =C2=A0 =C2=A0 tmp =3D str;
>  =C2=A0 =C2=A0 =C2=A0 end =3D str + str_len;
>
> - =C2=A0 =C2=A0 =C2=A0 /* it is really faster to scan twice and allocate =
mem once insted
> scanning once
> + =C2=A0 =C2=A0 =C2=A0 /* it is really faster to scan twice and allocate =
mem once instead
> scanning once
>  =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0and constantly reallocing */
>  =C2=A0 =C2=A0 =C2=A0 while (tmp < end) {
>  =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (*tmp =3D=3D '\r') {
>
>
>
> This typo and the grammatical error are fixed now.
>
>
>
>
> besides, I have a question: why not function nl2br just replace the "\r\n=
",
> "\n", "\r" things with "<br/>"? why insert "<br/>" before those "\r\n",
> "\n", "\r"?
>
>
>
> Because its much easier to read the output when the newlines are preserve=
d.
>
> Scott
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>