Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45956 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33301 invoked from network); 5 Nov 2009 19:20:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Nov 2009 19:20:12 -0000 Authentication-Results: pb1.pair.com smtp.mail=yoarvi@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yoarvi@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.222.172 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: yoarvi@gmail.com X-Host-Fingerprint: 209.85.222.172 mail-pz0-f172.google.com Received: from [209.85.222.172] ([209.85.222.172:63895] helo=mail-pz0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4E/64-08268-B6523FA4 for ; Thu, 05 Nov 2009 14:20:12 -0500 Received: by pzk2 with SMTP id 2so196395pzk.26 for ; Thu, 05 Nov 2009 11:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=A+3E0AKEIuVRgqbKikNe+0YhgG4jAfNuncMJfrsLIvY=; b=VSnBTj7O2aAm4XpRD78bVlb9gegr12A7G911aMIQFcelz3BRZuivLd+y1D9RNHtzzb 6nYz4jEktNXtKP/YbeMYiy69EVKqNXDMyYbqj7I3UVSVOh63HG+ZnL/FzDhwfRIIFG8U UNb5PMGo2qCLCbhsq8iYQfmqVlD3VIjQbTJDo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=F9mijryF+x0IZpDGBupaTdmocPhgmqZ20rvbodahESmIwi5KK2y23ffePw+NLDcajr F/W8bK3Cm34uFBaJJ9R2NiyGR4wD1CfRguU7kkxexX8nfZfcVUBPv4jTM9p06+6ppunU 6Fp63vS7/s6w1uyd+ljO3IoXqy1Z15hjE9ugM= MIME-Version: 1.0 Received: by 10.142.7.40 with SMTP id 40mr351930wfg.120.1257448809212; Thu, 05 Nov 2009 11:20:09 -0800 (PST) In-Reply-To: <4AF3206D.8050606@oracle.com> References: <4AF3206D.8050606@oracle.com> Date: Fri, 6 Nov 2009 00:50:09 +0530 Message-ID: To: Christopher Jones Cc: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro From: yoarvi@gmail.com (Arvind Srinivasan) > Does the GLOBALS_ID_BASE idea work? =A0In > "ts_allocate_reserved_id(GLOBALS_ID_BASE+1...)" each extension would > anyway need to reserve an increment to avoid clashes. =A0Also, why is I didn't really try using this. When I added it, I thought it might be useful for modules that live outside the PHP source tree. They could then define their constants using #define FOO_ID (GLOBALS_ID_BASE + 3) rather than hardcoding 33. As you point out, they would still need to reserve an increment. > GLOBALS_ID_BASE 30 when the largest reserved value is 18? =A0Maybe I'm > missing something. > I reserved IDs for the subsystems I thought were core. I was sure there'd be others that I'd missed and so I left space for more. > Would there be significant memory space or locality issues if one ID > per extension in the PHP source bundle was reserved upfront, even if > those extensions were never enabled? > I'll run some tests and see what impact this has. Arvi