Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45911 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 1068 invoked from network); 30 Oct 2009 11:47:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2009 11:47:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=yoarvi@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yoarvi@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: yoarvi@gmail.com X-Host-Fingerprint: 209.85.216.178 mail-px0-f178.google.com Received: from [209.85.216.178] ([209.85.216.178:49774] helo=mail-px0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E4/06-57355-652DAEA4 for ; Fri, 30 Oct 2009 06:47:34 -0500 Received: by pxi8 with SMTP id 8so1957683pxi.27 for ; Fri, 30 Oct 2009 04:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=mQ1I4bacEMvGHMdOVWUy+e97gVfU/5F/nwl4T0bAjeM=; b=J9lBfBvB4+b+foYVCgD4BhX+quXV95yfRsJHIkX8Bx2UUAVoysVBkBhML0nfsscNd5 ZF3Qf6IMeC0824WNab40TEk4mOeawj8jr4kPLlRSzHdDF+W1e2dYv9gWtWDfHYoFCJyd MP9SO9MhuF+o1QG6BsCVshlIRyDDscJ7RdidI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=VcL1dd37xQ9nChXkenMHKQnNvVbBsaO+L0FnaGBEKlCuBDG57l69jwHSYsGTZBuqSS paB9ReqlEaXmU3p/y5xlf1whWroYRXtF+1TnHe/gylNoIhiD8R7/RB2vxLrZGP+MTXMy ZKp+ZthT55JJlCQBbbPgHnLvMWwVJ2tBLAsXo= MIME-Version: 1.0 Received: by 10.142.5.29 with SMTP id 29mr156184wfe.75.1256903252070; Fri, 30 Oct 2009 04:47:32 -0700 (PDT) Date: Fri, 30 Oct 2009 17:17:32 +0530 Message-ID: To: internals@lists.php.net Content-Type: multipart/mixed; boundary=00504502b18fdb536f047725979f Subject: [PATCH] - Avoid unnecessary strlen in PHP's NSAPI plugin From: yoarvi@gmail.com (Arvind Srinivasan) --00504502b18fdb536f047725979f Content-Type: text/plain; charset=ISO-8859-1 Please review the attached patch which avoids an unnecessary strlen call (in the NSAPI plugin for PHP) by using php_register_variable_safe instead of php_register_variable. thanks, arvi --00504502b18fdb536f047725979f Content-Type: text/plain; charset=US-ASCII; name="nsapi3-patch.txt" Content-Disposition: attachment; filename="nsapi3-patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g1ew7joj0 ZGlmZiAtciA2NGYyNGEyMmY1MTggc2FwaS9uc2FwaS9uc2FwaS5jCi0tLSBhL3NhcGkvbnNhcGkv bnNhcGkuYwlXZWQgQXVnIDI2IDE3OjMzOjA2IDIwMDkgKzA1MzAKKysrIGIvc2FwaS9uc2FwaS9u c2FwaS5jCVRodSBBdWcgMjcgMTc6MjY6NTUgMjAwOSArMDUzMApAQCAtNzQ2LDIxICs3NDYsMTYg QEAKIAkJCQllZnJlZSh2YWx1ZSk7CiAJCQl9CiAJCX0gZWxzZSB7Ci0JCQlwaHBfcmVnaXN0ZXJf dmFyaWFibGUoIlJFUVVFU1RfVVJJIiwgU0cocmVxdWVzdF9pbmZvKS5yZXF1ZXN0X3VyaSwgdHJh Y2tfdmFyc19hcnJheSBUU1JNTFNfQ0MpOworCQkJcGhwX3JlZ2lzdGVyX3ZhcmlhYmxlX3NhZmUo IlJFUVVFU1RfVVJJIiwgU0cocmVxdWVzdF9pbmZvKS5yZXF1ZXN0X3VyaSwgcG9zLCB0cmFja192 YXJzX2FycmF5IFRTUk1MU19DQyk7CiAJCX0KIAotCQlpZiAodmFsdWUgPSBuc2FwaV9zdHJkdXAo U0cocmVxdWVzdF9pbmZvKS5yZXF1ZXN0X3VyaSkpIHsKLQkJCWlmIChyYy0+cGF0aF9pbmZvKSB7 Ci0JCQkJcG9zID0gc3RybGVuKFNHKHJlcXVlc3RfaW5mbykucmVxdWVzdF91cmkpIC0gc3RybGVu KHJjLT5wYXRoX2luZm8pOwotCQkJCWlmIChwb3M+PTApIHsKLQkJCQkJdmFsdWVbcG9zXSA9ICdc MCc7Ci0JCQkJfSBlbHNlIHsKLQkJCQkJdmFsdWVbMF09J1wwJzsKLQkJCQl9CisJCWlmIChyYy0+ cGF0aF9pbmZvKSB7CisJCQlwb3MgLT0gc3RybGVuKHJjLT5wYXRoX2luZm8pOworCQkJaWYgKHBv czwwKSB7CisJCQkJcG9zID0gMDsKIAkJCX0KLQkJCXBocF9yZWdpc3Rlcl92YXJpYWJsZSgiU0NS SVBUX05BTUUiLCB2YWx1ZSwgdHJhY2tfdmFyc19hcnJheSBUU1JNTFNfQ0MpOwotCQkJbnNhcGlf ZnJlZSh2YWx1ZSk7CiAJCX0KKwkJcGhwX3JlZ2lzdGVyX3ZhcmlhYmxlX3NhZmUoIlNDUklQVF9O QU1FIiwgdmFsdWUsIHBvcywgdHJhY2tfdmFyc19hcnJheSBUU1JNTFNfQ0MpOwogCX0KIAlwaHBf cmVnaXN0ZXJfdmFyaWFibGUoIlNDUklQVF9GSUxFTkFNRSIsIFNHKHJlcXVlc3RfaW5mbykucGF0 aF90cmFuc2xhdGVkLCB0cmFja192YXJzX2FycmF5IFRTUk1MU19DQyk7CiAK --00504502b18fdb536f047725979f--