Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45910 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99708 invoked from network); 30 Oct 2009 11:45:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2009 11:45:01 -0000 Authentication-Results: pb1.pair.com header.from=yoarvi@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=yoarvi@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: yoarvi@gmail.com X-Host-Fingerprint: 209.85.216.178 mail-px0-f178.google.com Received: from [209.85.216.178] ([209.85.216.178:61631] helo=mail-px0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BF/B5-57355-CB1DAEA4 for ; Fri, 30 Oct 2009 06:45:00 -0500 Received: by pxi8 with SMTP id 8so1956719pxi.27 for ; Fri, 30 Oct 2009 04:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=mpPrvQgBBRVsTQ67n2CuhU+Xy/1X3O6Nb1A6Yvw52wc=; b=iM8fe5Wgz3FM5gEXMXMMc18iAPd+Fc6BJ8NODTcAwqnKDZAVcL0veHmsKPHdZxP6mw fcURR8d6BbnRERpqXXJClf/xDgFoU8kiIoAi01R+L14ioBI8ucv194mPQ9wKVBVbTEzd 4ZQlx8EDQkQuWN2RX4XNlO3iA55H5lKuvgLOo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=BRICgijjvpDGs6N4kQAFtM4Gp8FP6fxNpqm0dPdwTEYyw6UBwPJDDMacWsNqmuHrpw W0vE9GK4nauEYgEOyHaFkNF0hSEs5Iluw0sIlwxxdL6ULgeptUSxiRDV5yMh3Z+sjoiI hoUlpgDIWicZ7632MFPCl+bfMmtLdxcTDHilw= MIME-Version: 1.0 Received: by 10.142.60.3 with SMTP id i3mr136283wfa.147.1256903097466; Fri, 30 Oct 2009 04:44:57 -0700 (PDT) Date: Fri, 30 Oct 2009 17:14:57 +0530 Message-ID: To: internals@lists.php.net Content-Type: multipart/mixed; boundary=00504502ad14a43dfa0477258e00 Subject: [PATCH] - Remove unnecessary strdup calls in the NSAPI plugin for PHP From: yoarvi@gmail.com (Arvind Srinivasan) --00504502ad14a43dfa0477258e00 Content-Type: text/plain; charset=ISO-8859-1 Please review the attached patch which removes unnecessary strdup calls in PHP's NSAPI plugin for Sun Web Server. The strings are unaltered in the SG(request_info) structure so there isn't any need to strdup them. thanks, arvi --00504502ad14a43dfa0477258e00 Content-Type: text/plain; charset=US-ASCII; name="nsapi2-patch.txt" Content-Disposition: attachment; filename="nsapi2-patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g1ew42p40 ZGlmZiAtciA5NGYwMjE4M2ExNzUgc2FwaS9uc2FwaS9uc2FwaS5jCi0tLSBhL3NhcGkvbnNhcGkv bnNhcGkuYwlXZWQgQXVnIDI2IDE3OjExOjQ2IDIwMDkgKzA1MzAKKysrIGIvc2FwaS9uc2FwaS9u c2FwaS5jCVdlZCBBdWcgMjYgMTc6MzM6MDYgMjAwOSArMDUzMApAQCAtMTAxMCwxNCArMTAxMCwx NCBAQAogCXJlcXVlc3RfY29udGV4dC0+cmVhZF9wb3N0X2J5dGVzID0gMDsKIAlyZXF1ZXN0X2Nv bnRleHQtPmZpeGVkX3NjcmlwdCA9IGZpeGVkX3NjcmlwdDsKIAlyZXF1ZXN0X2NvbnRleHQtPmh0 dHBfZXJyb3IgPSAoZXJyb3JfZGlyZWN0aXZlKSA/IHJxLT5zdGF0dXNfbnVtIDogMDsKLQlyZXF1 ZXN0X2NvbnRleHQtPnBhdGhfaW5mbyA9IG5zYXBpX3N0cmR1cChwYXRoX2luZm8pOworCXJlcXVl c3RfY29udGV4dC0+cGF0aF9pbmZvID0gcGF0aF9pbmZvOwogCiAJU0coc2VydmVyX2NvbnRleHQp ID0gcmVxdWVzdF9jb250ZXh0OwotCVNHKHJlcXVlc3RfaW5mbykucXVlcnlfc3RyaW5nID0gbnNh cGlfc3RyZHVwKHF1ZXJ5X3N0cmluZyk7Ci0JU0cocmVxdWVzdF9pbmZvKS5yZXF1ZXN0X3VyaSA9 IG5zYXBpX3N0cmR1cCh1cmkpOwotCVNHKHJlcXVlc3RfaW5mbykucmVxdWVzdF9tZXRob2QgPSBu c2FwaV9zdHJkdXAocmVxdWVzdF9tZXRob2QpOwotCVNHKHJlcXVlc3RfaW5mbykucGF0aF90cmFu c2xhdGVkID0gbnNhcGlfc3RyZHVwKHBhdGhfdHJhbnNsYXRlZCk7Ci0JU0cocmVxdWVzdF9pbmZv KS5jb250ZW50X3R5cGUgPSBuc2FwaV9zdHJkdXAoY29udGVudF90eXBlKTsKKwlTRyhyZXF1ZXN0 X2luZm8pLnF1ZXJ5X3N0cmluZyA9IHF1ZXJ5X3N0cmluZzsKKwlTRyhyZXF1ZXN0X2luZm8pLnJl cXVlc3RfdXJpID0gdXJpOworCVNHKHJlcXVlc3RfaW5mbykucmVxdWVzdF9tZXRob2QgPSByZXF1 ZXN0X21ldGhvZDsKKwlTRyhyZXF1ZXN0X2luZm8pLnBhdGhfdHJhbnNsYXRlZCA9IHBhdGhfdHJh bnNsYXRlZDsKKwlTRyhyZXF1ZXN0X2luZm8pLmNvbnRlbnRfdHlwZSA9IGNvbnRlbnRfdHlwZTsK IAlTRyhyZXF1ZXN0X2luZm8pLmNvbnRlbnRfbGVuZ3RoID0gKGNvbnRlbnRfbGVuZ3RoID09IE5V TEwpID8gMCA6IHN0cnRvdWwoY29udGVudF9sZW5ndGgsIDAsIDApOwogCVNHKHNhcGlfaGVhZGVy cykuaHR0cF9yZXNwb25zZV9jb2RlID0gKGVycm9yX2RpcmVjdGl2ZSkgPyBycS0+c3RhdHVzX251 bSA6IDIwMDsKIAkKQEAgLTEwNTcsMTMgKzEwNTcsNiBAQAogCQl9CiAJfQogCi0JbnNhcGlfZnJl ZShyZXF1ZXN0X2NvbnRleHQtPnBhdGhfaW5mbyk7Ci0JbnNhcGlfZnJlZShTRyhyZXF1ZXN0X2lu Zm8pLnF1ZXJ5X3N0cmluZyk7Ci0JbnNhcGlfZnJlZShTRyhyZXF1ZXN0X2luZm8pLnJlcXVlc3Rf dXJpKTsKLQluc2FwaV9mcmVlKCh2b2lkKikoU0cocmVxdWVzdF9pbmZvKS5yZXF1ZXN0X21ldGhv ZCkpOwotCW5zYXBpX2ZyZWUoU0cocmVxdWVzdF9pbmZvKS5wYXRoX3RyYW5zbGF0ZWQpOwotCW5z YXBpX2ZyZWUoKHZvaWQqKShTRyhyZXF1ZXN0X2luZm8pLmNvbnRlbnRfdHlwZSkpOwotCiAJcG9v bF9mcmVlKHNuLT5wb29sLCByZXF1ZXN0X2NvbnRleHQpOwogCVNHKHNlcnZlcl9jb250ZXh0KSA9 IE5VTEw7CiAK --00504502ad14a43dfa0477258e00--