Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45908 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88252 invoked from network); 30 Oct 2009 10:12:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2009 10:12:50 -0000 Authentication-Results: pb1.pair.com header.from=yoarvi@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=yoarvi@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: yoarvi@gmail.com X-Host-Fingerprint: 209.85.216.178 mail-px0-f178.google.com Received: from [209.85.216.178] ([209.85.216.178:40342] helo=mail-px0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D6/54-57355-22CBAEA4 for ; Fri, 30 Oct 2009 05:12:50 -0500 Received: by pxi8 with SMTP id 8so1922353pxi.27 for ; Fri, 30 Oct 2009 03:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=lvuc3SbyQ1ebja5iyhJyoL7ZdN7s3LPiUWM44IkKziE=; b=jkm9dg03qx9Ne0OuLS8jY5AlcCFYKcQot6oySwPwXloR5Ddps1jdq8ZN8jD5nXRILm b+hqAsWksr1H5hmFqwEB3o9T5fsl+KEcH6vOzy6ekJFZ+2nWD2exCaVsCOO6Zq4jhUo4 HchdwZY1deviujH3iJy42GuPVDC8Bd7WxYN5M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=PqdeKbxgXAxESglQSgHqnt42de1axlmKX8fjlstJPOwXtLZoCja6EiVWrhy/Qrfy8t Fy5OcL5SYj+zCxnmlhuQayIIgQxqr9pgszo12nJs8x5Bw/DsO0PsaBBLbamzR5Nr2xAC A4GEnCcAM8um+TZGCU7Mb7ove7rN9XOypTqJQ= MIME-Version: 1.0 Received: by 10.142.74.16 with SMTP id w16mr145249wfa.200.1256897567717; Fri, 30 Oct 2009 03:12:47 -0700 (PDT) Date: Fri, 30 Oct 2009 15:42:47 +0530 Message-ID: To: internals@lists.php.net Content-Type: multipart/mixed; boundary=001636e90b7a0af8b60477244510 Subject: [PATCH] - Avoid invoking setitimer when timeouts have been disabled From: yoarvi@gmail.com (Arvind Srinivasan) --001636e90b7a0af8b60477244510 Content-Type: text/plain; charset=ISO-8859-1 When compiled with #ifdef ZTS, the setitimer calls in zend_unset_timeout show up as a performance hotspot even when I'd set max_execution_time and max_input_time to 0 in php.ini. I've attached a patch for review that avoids invoking zend_unset_timeout (and thereby the expensive setitimer call within) when timeouts have been disabled via settings in php.ini Thanks, Arvi --001636e90b7a0af8b60477244510 Content-Type: text/plain; charset=US-ASCII; name="setitimer-patch.txt" Content-Disposition: attachment; filename="setitimer-patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g1esjqie0 ZGlmZiAtciBkMGRkZGViYWUzYTIgbWFpbi9tYWluLmMKLS0tIGEvbWFpbi9tYWluLmMJTW9uIE1h eSAwNCAxODoxMTo1MCAyMDA5ICswMjAwCisrKyBiL21haW4vbWFpbi5jCUZyaSBBdWcgMjggMTc6 MzU6MjUgMjAwOSArMDUzMApAQCAtMTYwMiw3ICsxNjAyLDkgQEAKIAl9IHplbmRfZW5kX3RyeSgp OwogCiAJemVuZF90cnkgewotCQl6ZW5kX3Vuc2V0X3RpbWVvdXQoVFNSTUxTX0MpOworCQlpZiAo RUcodGltZW91dF9zZWNvbmRzKSAhPSAwKSB7CisJCQl6ZW5kX3Vuc2V0X3RpbWVvdXQoVFNSTUxT X0MpOworCQl9CiAJfSB6ZW5kX2VuZF90cnkoKTsKIH0KIApAQCAtMTcwMiw3ICsxNzA0LDkgQEAK IAogCS8qIDEyLiBSZXNldCBtYXhfZXhlY3V0aW9uX3RpbWUgKi8KIAl6ZW5kX3RyeSB7Ci0JCXpl bmRfdW5zZXRfdGltZW91dChUU1JNTFNfQyk7CisJCWlmIChFRyh0aW1lb3V0X3NlY29uZHMpICE9 IDApIHsKKwkJCXplbmRfdW5zZXRfdGltZW91dChUU1JNTFNfQyk7CisJCX0KIAl9IHplbmRfZW5k X3RyeSgpOwogCiAjaWZkZWYgUEhQX1dJTjMyCg== --001636e90b7a0af8b60477244510--