Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45725
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.154 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=U7sf2Awv7/Z4tKuMF6NgwzqQtx8UzRPGjs4oC5IXBafKAWZEt5+CDT///kaVYyrSd3
         4mBUtpnCGMHnJXI4yhxNGLr8avELhY3SPtu0BXb8bUfLY5x/PFfIZ1E9L3KOGHiLIj32
         n4m3VmIVM/oWoQYfPny4greiLsWIt8vM0pVns=
MIME-Version: 1.0
In-Reply-To: <4AD191B7.6080803@tekrat.com>
References: <4AD191B7.6080803@tekrat.com>
Date: Sun, 11 Oct 2009 15:01:03 +0200
Message-ID: <fe05d1540910110601v109a8bcai4bd1f56b155c8f68@mail.gmail.com>
To: shire <shire@tekrat.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC: php_config --extra_includes
From: pierre.php@gmail.com (Pierre Joye)

hi!

On Sun, Oct 11, 2009 at 10:05 AM, shire <shire@tekrat.com> wrote:
>
> Currently we have an open bug #16809
> (http://pecl.php.net/bugs/bug.php?id=3D16809&edit=3D1) in APC where we're=
 unable
> to find the pcre.h header file as it's not in our include path when a use=
r
> compiles PHP with the --enable-pcre=3D<some include path>. =A0This is bec=
ause
> the include path the user provides isn't made available in INCLUDES in th=
e
> extension (APC) when compiled as a shared library using phpize.
>
> I've come up with the following solution, but want feedback/other options
> before I commit. =A0Essentially I've made use of the EXTRA_INCLUDES that'=
s
> included in INCLUDES, but not really used much of anywhere AFAIK. =A0I've=
 also
> added the autoconf macro PHP_ADD_EXTRA_INCLUDE that mirrors the
> PHP_ADD_INCLUDE behavior, as well as the --extra_includes option to
> php-config. =A0This way extensions can provide additional include paths t=
hat
> they depend on for extensions that may in-turn be dependent on their head=
er
> files.
>
> http://tekrat.com/downloads/bits/extra_includes.php5.3.patch

Would it be not more correct to test if the bundled pcre is used or
not. And detect the pcre header if the system pcre is used?

Cheers,
--=20
Pierre

http://blog.thepimp.net | http://www.libgd.org