Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45695
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 84666 invoked from network); 7 Oct 2009 14:24:40 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 7 Oct 2009 14:24:40 -0000
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.156 as permitted sender)
DomainKey-Status: bad
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 72.14.220.156 fg-out-1718.google.com  
Received: from [72.14.220.156] ([72.14.220.156:22342] helo=fg-out-1718.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 1B/5D-13083-DFB9CCA4 for <internals@lists.php.net>; Wed, 07 Oct 2009 09:47:42 -0400
Received: by fg-out-1718.google.com with SMTP id e12so861959fga.11
        for <internals@lists.php.net>; Wed, 07 Oct 2009 06:47:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=tvK1JJfWD1nlUfrZSfD6EOdj0ZhruJI69C9HtoGXmmc=;
        b=BXPbuqGxW4mBFFigVRup/j/sn/QMANdosDLL7Si5ZyhmAqOSusC2U4Tfz8Acq4MPGM
         j1bEBchEdJrRMjVEBSqMjAPqeNL1nWnRRVzzCjqmLml+KUHFbVt1/30jLcJZR5zDjco3
         L+af1f6ZRIG3N1BOhBw3yhOYLRpIgjZifSYbw=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=DJ34PoNm82ad4XqlpeXjNQblm3khmGH6MpOfAUM9ILl+2+3MQgzmJu88XyDN6rUlQP
         SWB+YqWuqurxpZqUzg0JDfekv9RmY0dCXnQOFzRs3h4VY179fPEmg9iYSNXJsjMYYvIX
         H6AKgbMrVMNKF8Xi0w0l8PtVMVkYwUvXNUyGk=
MIME-Version: 1.0
Received: by 10.86.231.15 with SMTP id d15mr426fgh.74.1254923258070; Wed, 07 
	Oct 2009 06:47:38 -0700 (PDT)
In-Reply-To: <1254922168.566.4.camel@samuel-laptop>
References: <1254806557.19561.3.camel@samuel-laptop>
	 <1254807735.19561.5.camel@samuel-laptop>
	 <4ACAF18B.5080803@beccati.com> <1254846564.876.1.camel@samuel-laptop>
	 <4ACBC540.4090308@beccati.com>
	 <1254895026.7418.36.camel@samuel-laptop>
	 <1254922168.566.4.camel@samuel-laptop>
Date: Wed, 7 Oct 2009 15:47:38 +0200
Message-ID: <fe05d1540910070647l183d6b1y9b8fa19249d48765@mail.gmail.com>
To: Samuel ROZE <samuel.roze@aliceadsl.fr>
Cc: Matteo Beccati <php@beccati.com>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PDO PgSQL: _pdo_pgsql_notice
From: pierre.php@gmail.com (Pierre Joye)

hi,

The idea is good and matches my thoughts on this topic.

Some comments:
- no driver specific API, so getNotices instaed of get<driver>Notices
- common attribute name as well and maybe a better naming ATTR_LOG_NOTICES?

5.2 is also only for security fixes. Can you try to produce a patch
against 5.3 and trunk please?

Cheers,

On Wed, Oct 7, 2009 at 3:29 PM, Samuel ROZE <samuel.roze@aliceadsl.fr> wrot=
e:
> Le mercredi 07 octobre 2009 =E0 07:57 +0200, Samuel ROZE a =E9crit :
>> Well, i've show the patch this morning... It's great ! The allocation of
>> the HashTable when use setAttribute might not be really a good job but
>> other, in my mind, is !
>>
>> See you afternoon for PHP 5.2 path. :-)
>
> Well, I've done a patch for PHP 5.2 branch:
> http://www.d-sites.com/wp-content/uploads/2009/10/pdo_pgsql_notices_php5.=
2.patch
>
> It is working but there are two memory leaks when running with CGI:
>
> [Wed Oct =A07 15:20:10 2009] =A0Script: =A0'pgsql_notice.php'
> /usr/src/php-5.2.10/ext/pdo_pgsql/pgsql_driver.c(105) : =A0Freeing
> 0x01C43A80 (24 bytes), script=3Dpgsql_notice.php
> [Wed Oct =A07 15:20:10 2009] =A0Script: =A0'pgsql_notice.php'
> /usr/src/php-5.2.10/ext/pdo_pgsql/pgsql_driver.c(55) : =A0Freeing
> 0x01C43AF0 (22 bytes), script=3Dpgsql_notice.php
> =3D=3D=3D Total 2 memory leaks detected =3D=3D=3D
>
> Joined, the pgsql_driver.c file.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Pierre

http://blog.thepimp.net | http://www.libgd.org