Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45691
Return-Path: <samuel.roze@aliceadsl.fr>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 77629 invoked from network); 7 Oct 2009 13:55:48 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 7 Oct 2009 13:55:48 -0000
Authentication-Results: pb1.pair.com header.from=samuel.roze@aliceadsl.fr; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=samuel.roze@aliceadsl.fr; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain aliceadsl.fr from 212.27.42.3 cause and error)
X-PHP-List-Original-Sender: samuel.roze@aliceadsl.fr
X-Host-Fingerprint: 212.27.42.3 smtp3-g21.free.fr Linux 2.6
Received: from [212.27.42.3] ([212.27.42.3:50836] helo=smtp3-g21.free.fr)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 08/9D-13083-EDD9CCA4 for <internals@lists.php.net>; Wed, 07 Oct 2009 09:55:46 -0400
Received: from smtp3-g21.free.fr (localhost [127.0.0.1])
	by smtp3-g21.free.fr (Postfix) with ESMTP id A34A88181C0;
	Wed,  7 Oct 2009 15:55:36 +0200 (CEST)
Received: from [192.168.0.10] (lns-bzn-46-82-253-200-55.adsl.proxad.net [82.253.200.55])
	by smtp3-g21.free.fr (Postfix) with ESMTP id 6FAD081815D;
	Wed,  7 Oct 2009 15:55:33 +0200 (CEST)
To: Pierre Joye <pierre.php@gmail.com>
Cc: Matteo Beccati <php@beccati.com>, internals@lists.php.net
In-Reply-To: <fe05d1540910070647l183d6b1y9b8fa19249d48765@mail.gmail.com>
References: <1254806557.19561.3.camel@samuel-laptop>
	 <1254807735.19561.5.camel@samuel-laptop> <4ACAF18B.5080803@beccati.com>
	 <1254846564.876.1.camel@samuel-laptop> <4ACBC540.4090308@beccati.com>
	 <1254895026.7418.36.camel@samuel-laptop>
	 <1254922168.566.4.camel@samuel-laptop>
	 <fe05d1540910070647l183d6b1y9b8fa19249d48765@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 07 Oct 2009 15:55:48 +0200
Message-ID: <1254923748.566.10.camel@samuel-laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.1 
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] PDO PgSQL: _pdo_pgsql_notice
From: samuel.roze@aliceadsl.fr (Samuel ROZE)

Le mercredi 07 octobre 2009 à 15:47 +0200, Pierre Joye a écrit :
> The idea is good and matches my thoughts on this topic.
> 
> Some comments:
> - no driver specific API, so getNotices instaed of get<driver>Notices

It was discuss, it need hours to implement this method to all
drivers... 

> - common attribute name as well and maybe a better naming ATTR_LOG_NOTICES?

Why not, but it must be in the same time that the last question

> 5.2 is also only for security fixes. Can you try to produce a patch
> against 5.3 and trunk please?

There's the patch of Matteo Beccati at this address for PHP 5.3:
http://www.beccati.com/misc/php/pdo_pgsql_notices_php5_3.patch

I can make another for the trunk, why not :-). I'll probably try to make
this functionality as global today or tomorrow.

Thanks for your feedback.
Samuel.

> Cheers,
> 
> On Wed, Oct 7, 2009 at 3:29 PM, Samuel ROZE <samuel.roze@aliceadsl.fr> wrote:
> > Le mercredi 07 octobre 2009 à 07:57 +0200, Samuel ROZE a écrit :
> >> Well, i've show the patch this morning... It's great ! The allocation of
> >> the HashTable when use setAttribute might not be really a good job but
> >> other, in my mind, is !
> >>
> >> See you afternoon for PHP 5.2 path. :-)
> >
> > Well, I've done a patch for PHP 5.2 branch:
> > http://www.d-sites.com/wp-content/uploads/2009/10/pdo_pgsql_notices_php5.2.patch
> >
> > It is working but there are two memory leaks when running with CGI:
> >
> > [Wed Oct  7 15:20:10 2009]  Script:  'pgsql_notice.php'
> > /usr/src/php-5.2.10/ext/pdo_pgsql/pgsql_driver.c(105) :  Freeing
> > 0x01C43A80 (24 bytes), script=pgsql_notice.php
> > [Wed Oct  7 15:20:10 2009]  Script:  'pgsql_notice.php'
> > /usr/src/php-5.2.10/ext/pdo_pgsql/pgsql_driver.c(55) :  Freeing
> > 0x01C43AF0 (22 bytes), script=pgsql_notice.php
> > === Total 2 memory leaks detected ===
> >
> > Joined, the pgsql_driver.c file.
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> 
> 
>