Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:4563
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <1064351733.2gqn7u1ekkqo@localhost>
Date: Tue, 23 Sep 2003 23:15:33 +0200
To: internals@lists.php.net
References: <1064324106.4qf5jx9xw2yo@217.255.147.155>
	<20030923154431.28056.qmail@pb1.pair.com>
	<05a601c381f3$f36e8b50$0702a8c0@TITAN>
	<200309231345.58072.ilia@prohost.org> <1064349699.7zp9rs5gnic@localhost>
	<20030923210103.70589.qmail@pb1.pair.com>
In-Reply-To: <20030923210103.70589.qmail@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-15"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) 4.0-cvs
Subject: Re: [PHP-DEV] Re: Fwd: Re: #25494 [Com]: array_merge allowing
	"false" as argument (silent when non-array is passed)
From: jan@horde.org (Jan Schneider)

Zitat von Jay Smith <jay@php.net>:

> Jan Schneider wrote:
>
> >
> > I generally agree (this is the purpose of E_NOTICE after all), but
> there
> > is a subtle difference between what has been fixed and what is broken
> now.
> > Passing NULLs to array_merge didn't lead to the borked arrays that have
> > been "fixed" by this patch.
> >
>
> How are the arrays borked? The patch doesn't touch, skip or otherwise do
> anything to any of the parameters, it just does a type check. Am I
> missing
> something here? (Which is quite possible...)

Ah, well, I misread the original bug report. With "borked" I meant that
array_merge(false, array("foo" => "bar")) resulted in array(0 => false,
"foo" => "bar"). I though this was changed by the patch.

Anyway, array_merge(array("foo" => "bar"), null) was never producing such an
array and should thus not result in an E_NOTICE.

Jan.

--
http://www.horde.org - The Horde Project
http://www.ammma.de - discover your knowledge
http://www.tip4all.de - Deine private Tippgemeinschaft