Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:4557
Return-Path: <jay@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 84506 invoked by uid 1010); 23 Sep 2003 17:42:49 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 84471 invoked by uid 1007); 23 Sep 2003 17:42:49 -0000
Message-ID: <20030923174248.84470.qmail@pb1.pair.com>
To: internals@lists.php.net
Reply-To: jay@php.net
Mail-Copies-To: jay@php.net
Date: Tue, 23 Sep 2003 13:42:47 -0400
References: <1064324106.4qf5jx9xw2yo@217.255.147.155> <20030923154431.28056.qmail@pb1.pair.com> <05a601c381f3$f36e8b50$0702a8c0@TITAN>
Lines: 21
User-Agent: KNode/0.7.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
X-Posted-By: 216.94.11.234
Subject: Re: [PHP-DEV] Re: Fwd: Re: #25494 [Com]: array_merge allowing "false" as argument (silent when non-array is passed)
From: jay@php.net (Jay Smith)

Wez Furlong wrote:

> 
> Actually, this is Ilia's decision, but I think we should not raise any
> notices for NULL values, for the sake of BC.  It really does suck to break
> code that was working with no problems in a minor release.
> 
> If the change had been made for 4.3, or 4.4 or 5, it wouldn't matter quite
> so much.
> But to change it for 4.3.4 !?
> 
> --Wez.

Point taken. I've got no great attachment to the "fix", although I do prefer
the consistency with the other array functions. 

Would checking for IS_ARRAY and IS_NULL be too much of a kludge?

J