Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45522
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain microsoft.com designates 131.107.115.214 as permitted sender)
To: Pierre Joye <pierre.php@gmail.com>
CC: =?iso-8859-1?Q?Hans_=C5hlin?= <ahlin.hans@kronan-net.com>,
	"internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Fix for 49148 (combination of stream_get_line and
 fseek 	does not work correctly)
Thread-Index: AQHKLFeaflnFil+xK0ucvYhc1Q54wZDFJA7ggAAuaHCAAAGYUIAAgBCAgAceW0A=
Date: Tue, 8 Sep 2009 17:05:04 +0000
Message-ID: <BC1CAE3856F0A143808A7796D62870A3016C4B2A@TK5EX14MBXC127.redmond.corp.microsoft.com>
References: <BC1CAE3856F0A143808A7796D62870A3016BCE55@TK5EX14MBXC127.redmond.corp.microsoft.com>
	 <4A9EE046.4090500@zend.com>
	 <72e33a530909022226u319b15fbt62cdd53648f1dbd3@mail.gmail.com>
	 <72e33a530909022229l72ffa77cx7f7b6981d08a41a1@mail.gmail.com>
	 <BC1CAE3856F0A143808A7796D62870A3016BF5BB@TK5EX14MBXC127.redmond.corp.microsoft.com>
	 <BC1CAE3856F0A143808A7796D62870A3016BF5E4@TK5EX14MBXC127.redmond.corp.microsoft.com>
	 <BC1CAE3856F0A143808A7796D62870A3016BF5F5@TK5EX14MBXC127.redmond.corp.microsoft.com>
 <fe05d1540909031415n6c85647dneb4964e37af6ef3e@mail.gmail.com>
In-Reply-To: <fe05d1540909031415n6c85647dneb4964e37af6ef3e@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and
 fseek 	does not work correctly)
From: garretts@microsoft.com (Garrett Serack)

Hmmm.

stream_get_line doesn't appear to work correctly with bz streams:

--example.php--
$tmpname =3D tempnam("/tmp", "tmp");
$tmp =3D fopen($tmpname, "w");
stream_filter_append($tmp, 'bzip2.compress', STREAM_FILTER_WRITE);
fwrite($tmp, "line1\n");
fwrite($tmp, "line2\n");
fwrite($tmp, "line3");
fclose($tmp);

// reopen for reading using stream_get_line
$tmp =3D fopen($tmpname, "r");
stream_filter_prepend($tmp, 'bzip2.decompress', STREAM_FILTER_READ);
var_dump(stream_get_line($tmp, null, "\n"));
var_dump(stream_get_line($tmp, null, "\n"));
var_dump(stream_get_line($tmp, null, "\n"));
var_dump(stream_get_line($tmp, null, "\n"));
fclose($tmp);

// reopen for reading again, this time using fgets()
$tmp =3D fopen($tmpname, "r");
stream_filter_prepend($tmp, 'bzip2.decompress', STREAM_FILTER_READ);
var_dump(fgets($tmp));
var_dump(fgets($tmp));
var_dump(fgets($tmp));
var_dump(fgets($tmp));
fclose($tmp);
--------------------

--output--
string(5) "line1"
string(0) ""
string(0) ""
string(0) ""
string(6) "line1
"
string(6) "line2
"
string(6) "line2
"
bool(false)
--------------------

Both pre- and post- patch, the stream_get_line doesn't work right with the =
bz stream. I get the first read ok, then subsequent ones don't work.

fgets() works perfectly fine however.

Perhaps the whole thing is a tad buggier than it should be.

Any ideas?

G
-----Original Message-----
From: Pierre Joye [mailto:pierre.php@gmail.com]=20
Sent: Thursday, September 03, 2009 2:16 PM
To: Garrett Serack
Cc: Hans =C5hlin; internals@lists.php.net
Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fs=
eek does not work correctly)

hi Garrett,

As the patch looks simple I still like to have a bunch set of other
tests before applying it (especially for 5.2/3). The tests should
ideally use various stream backends (user, bz, etc.).

Cheers,

On Thu, Sep 3, 2009 at 10:38 PM, Garrett Serack<garretts@microsoft.com> wro=
te:
> Ah, no. That is correctly handled. (the default max line length is 8k), a=
nd passing in a larger number works just fine.
>
> G
> -----Original Message-----
> From: Garrett Serack
> Sent: Thursday, September 03, 2009 1:32 PM
> To: Garrett Serack; Hans =C5hlin; internals@lists.php.net
> Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and =
fseek does not work correctly)
>
> Ah, I found another case... when the line length is longer than the read =
buffer. I'll post again in a few minutes.
>
> G
>
> -----Original Message-----
> From: Garrett Serack [mailto:garretts@microsoft.com]
> Sent: Thursday, September 03, 2009 1:22 PM
> To: Hans =C5hlin; internals@lists.php.net
> Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and =
fseek does not work correctly)
>
> Without the patch, That is what will you see (windows or linux). (Which i=
s wrong...)
>
> The patch corrects the case where the stream has been fseek'd to the last=
 line in the file, when the last line doesn't end with a line terminator. (=
where you see 'false' in the results).
>
> Without the patch, the code mistakenly checks for EOF *after* characters =
have been read in, which is completely unnecessary (and incorrect) since th=
e read operation has taken place already.
>
> There could be some question as to the proper behavior when the stream *i=
s* at EOF, and stream_get_line is called (return NULL or empty string), but=
 the behavior previously was to return the empty string (keep calling strea=
m_get_line and once you reach the end, you will just get empty strings).
>
> G
>
> -----Original Message-----
> From: ahlin.hans@gmail.com [mailto:ahlin.hans@gmail.com] On Behalf Of Han=
s =C5hlin
> Sent: Wednesday, September 02, 2009 10:29 PM
> To: internals@lists.php.net
> Subject: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fsee=
k does not work correctly)
>
> I just ran the test on Linux 2.6.29 FC11 Apache 2.2.13 and PHP 5.2.9
>
> Result:
>
> string 'line1' (length=3D5)
> string '' (length=3D0)
> string 'line1' (length=3D5)
> string '' (length=3D0)
> string 'line1' (length=3D5)
> string 'line2' (length=3D5)
> string 'line1' (length=3D5)
> boolean false
> string 'line1' (length=3D5)
> string 'line2' (length=3D5)
> string 'line1' (length=3D5)
> string 'line2' (length=3D5)
>
> --
> MvH / Hans =C5hlin
> Tel: +46761488019
> http//www.kronan-net.com/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>



--=20
Pierre

http://blog.thepimp.net | http://www.libgd.org

--=20
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php