Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45497
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.212 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=RRmpROPAeREbJ44Zce5l+BToeIW03XWP9+giNQZVoSrn2pbxVBF7UvMOSfcosM7Y5z
         lzmPP1gyJ/3+W5sP6MyGYZKbw9GKDB+PtUTXtH9dieM96KUZKStD6VE8bDibsRgzTevG
         57ufy7VQwiVgyPrls8Te8R76CmWubWdcn1w9A=
MIME-Version: 1.0
In-Reply-To: <4AA24FDB.90409@sci.fi>
References: <20090904081640.GA28685@joeysmith.com>
	 <753B9AED-C850-4EBA-A828-93A2542F81A2@macvicar.net>
	 <20090904083457.GC28685@joeysmith.com>
	 <698DE66518E7CA45812BD18E807866CE034153BA@us-ex1.zend.net>
	 <4AA24FDB.90409@sci.fi>
Date: Sat, 5 Sep 2009 14:03:29 +0200
Message-ID: <fe05d1540909050503w79d11284o3f1de5f53b49cf6d@mail.gmail.com>
To: jani.taskinen@iki.fi
Cc: Andi Gutmans <andi@zend.com>, Joey Smith <joey@joeysmith.com>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
From: pierre.php@gmail.com (Pierre Joye)

I'm not totally convinced by this argument. CGI is definitively a
different SAPI than CLI and can behave differently. It was a problem
before when we had only one command for both CLI and CGI, but that's
not the case anymore.

We should better document CLI and recommend to always install it shell
usage is planed (and distros should install it by default as well).

On Sat, Sep 5, 2009 at 1:47 PM, Jani Taskinen<jani.taskinen@sci.fi> wrote:
> It's very legit to use with CGI since you might not be able to run PHP an=
y
> other way. So this is definately a bug, CGI should handle it the same as
> CLI.
>
> The bug report clearly explains it too:
>
> =A0http://bugs.php.net/bug.php?id=3D49182
>
> --Jani
>
> Andi Gutmans wrote:
>>
>> Shebang is for command line scripts (php-cli). It does not make sense to
>> support it for Web server scripts. It just adds unnecessary
>> code/complexity to that code base. Removing the support from php-cgi was
>> really a remnant of the old days when cli and cgi were the same SAPI.
>> I think we are better off this way.
>>
>> Andi
>>
>>> -----Original Message-----
>>> From: Joey Smith [mailto:joey@joeysmith.com]
>>> Sent: Friday, September 04, 2009 1:35 AM
>>> To: internals@lists.php.net
>>> Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
>>>
>>> I definitely had the wrong changeset - sorry, Nuno. :) Looks
>>> like maybe 273177 is the problem child.
>>>
>>> http://tinyurl.com/lewcft
>>>
>>>
>>> On Fri, Sep 04, 2009 at 09:25:52AM +0100, Scott MacVicar wrote:
>>>>
>>>> On 4 Sep 2009, at 09:16, Joey Smith <joey@joeysmith.com> wrote:
>>>>
>>>>> I can understand not having the 'shebang skipping' code
>>>>> in both the SAPI *and* the scanner, but we probably
>>>>> need to have it in at least ONE of them. :)
>>>>>
>>>>> Per his email[1] almost a year ago, Dmitry removed the
>>>>> shebang line check from sapi/cgi/cgi_main.c in changeset
>>>>> 264153, saying:
>>>>> =A0 Removed shebang line check from CGI sapi (it is
>>>>> =A0 =A0 =A0 checked by scanner)
>>>>>
>>>>> In http://tinyurl.com/me8528 (changeset 262275), nlopess
>>>>> removed the code from the scanner.
>>>>>
>>>>> Oops?
>>>>
>>>> What's the problem your having? The skip code is still there just in
>>
>> a
>>>>
>>>> different bit.
>>>>
>>>> Scott
>>>>
>>>> --
>>>> PHP Internals - PHP Runtime Development Mailing List
>>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Pierre

http://blog.thepimp.net | http://www.libgd.org