Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45495
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 204.13.248.71 cause and error)
Message-ID: <4AA24FDB.90409@sci.fi>
Date: Sat, 05 Sep 2009 14:47:39 +0300
Reply-To: jani.taskinen@iki.fi
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Andi Gutmans <andi@zend.com>
CC: Joey Smith <joey@joeysmith.com>, internals@lists.php.net
References: <20090904081640.GA28685@joeysmith.com> <753B9AED-C850-4EBA-A828-93A2542F81A2@macvicar.net> <20090904083457.GC28685@joeysmith.com> <698DE66518E7CA45812BD18E807866CE034153BA@us-ex1.zend.net>
In-Reply-To: <698DE66518E7CA45812BD18E807866CE034153BA@us-ex1.zend.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
From: jani.taskinen@sci.fi (Jani Taskinen)

It's very legit to use with CGI since you might not be able to run PHP any other 
way. So this is definately a bug, CGI should handle it the same as CLI.

The bug report clearly explains it too:

   http://bugs.php.net/bug.php?id=49182

--Jani

Andi Gutmans wrote:
> Shebang is for command line scripts (php-cli). It does not make sense to
> support it for Web server scripts. It just adds unnecessary
> code/complexity to that code base. Removing the support from php-cgi was
> really a remnant of the old days when cli and cgi were the same SAPI.
> I think we are better off this way.
> 
> Andi
> 
>> -----Original Message-----
>> From: Joey Smith [mailto:joey@joeysmith.com]
>> Sent: Friday, September 04, 2009 1:35 AM
>> To: internals@lists.php.net
>> Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
>>
>> I definitely had the wrong changeset - sorry, Nuno. :) Looks
>> like maybe 273177 is the problem child.
>>
>> http://tinyurl.com/lewcft
>>
>>
>> On Fri, Sep 04, 2009 at 09:25:52AM +0100, Scott MacVicar wrote:
>>>
>>> On 4 Sep 2009, at 09:16, Joey Smith <joey@joeysmith.com> wrote:
>>>
>>>> I can understand not having the 'shebang skipping' code
>>>> in both the SAPI *and* the scanner, but we probably
>>>> need to have it in at least ONE of them. :)
>>>>
>>>> Per his email[1] almost a year ago, Dmitry removed the
>>>> shebang line check from sapi/cgi/cgi_main.c in changeset
>>>> 264153, saying:
>>>>    Removed shebang line check from CGI sapi (it is
>>>>        checked by scanner)
>>>>
>>>> In http://tinyurl.com/me8528 (changeset 262275), nlopess
>>>> removed the code from the scanner.
>>>>
>>>> Oops?
>>> What's the problem your having? The skip code is still there just in
> a
>>> different bit.
>>>
>>> Scott
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
> 
>