Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45492
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 4 Sep 2009 20:51:39 -0700
Message-ID: <698DE66518E7CA45812BD18E807866CE034153BA@us-ex1.zend.net>
In-Reply-To: <20090904083457.GC28685@joeysmith.com>
Thread-Topic: [PHP-DEV] shebang skipping in 5.3.0
Thread-Index: AcotOq1kV/nY1Q7kTmuFHRGgvLpbgAAoTKFA
References: <20090904081640.GA28685@joeysmith.com> <753B9AED-C850-4EBA-A828-93A2542F81A2@macvicar.net> <20090904083457.GC28685@joeysmith.com>
To: "Joey Smith" <joey@joeysmith.com>
Cc: <internals@lists.php.net>
Subject: RE: [PHP-DEV] shebang skipping in 5.3.0
From: andi@zend.com ("Andi Gutmans")

Shebang is for command line scripts (php-cli). It does not make sense to
support it for Web server scripts. It just adds unnecessary
code/complexity to that code base. Removing the support from php-cgi was
really a remnant of the old days when cli and cgi were the same SAPI.
I think we are better off this way.

Andi

> -----Original Message-----
> From: Joey Smith [mailto:joey@joeysmith.com]
> Sent: Friday, September 04, 2009 1:35 AM
> To: internals@lists.php.net
> Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
>=20
> I definitely had the wrong changeset - sorry, Nuno. :) Looks
> like maybe 273177 is the problem child.
>=20
> http://tinyurl.com/lewcft
>=20
>=20
> On Fri, Sep 04, 2009 at 09:25:52AM +0100, Scott MacVicar wrote:
> >
> >
> > On 4 Sep 2009, at 09:16, Joey Smith <joey@joeysmith.com> wrote:
> >
> >> I can understand not having the 'shebang skipping' code
> >> in both the SAPI *and* the scanner, but we probably
> >> need to have it in at least ONE of them. :)
> >>
> >> Per his email[1] almost a year ago, Dmitry removed the
> >> shebang line check from sapi/cgi/cgi_main.c in changeset
> >> 264153, saying:
> >>    Removed shebang line check from CGI sapi (it is
> >>        checked by scanner)
> >>
> >> In http://tinyurl.com/me8528 (changeset 262275), nlopess
> >> removed the code from the scanner.
> >>
> >> Oops?
> >
> > What's the problem your having? The skip code is still there just in
a
> > different bit.
> >
> > Scott
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php