Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45488
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain joeysmith.com designates 209.90.98.146 as permitted sender)
Date: Fri, 4 Sep 2009 02:34:57 -0600
To: internals@lists.php.net
Message-ID: <20090904083457.GC28685@joeysmith.com>
References: <20090904081640.GA28685@joeysmith.com> <753B9AED-C850-4EBA-A828-93A2542F81A2@macvicar.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <753B9AED-C850-4EBA-A828-93A2542F81A2@macvicar.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
From: joey@joeysmith.com (Joey Smith)

I definitely had the wrong changeset - sorry, Nuno. :) Looks
like maybe 273177 is the problem child.

http://tinyurl.com/lewcft


On Fri, Sep 04, 2009 at 09:25:52AM +0100, Scott MacVicar wrote:
>
>
> On 4 Sep 2009, at 09:16, Joey Smith <joey@joeysmith.com> wrote:
>
>> I can understand not having the 'shebang skipping' code
>> in both the SAPI *and* the scanner, but we probably
>> need to have it in at least ONE of them. :)
>>
>> Per his email[1] almost a year ago, Dmitry removed the
>> shebang line check from sapi/cgi/cgi_main.c in changeset
>> 264153, saying:
>>    Removed shebang line check from CGI sapi (it is
>>        checked by scanner)
>>
>> In http://tinyurl.com/me8528 (changeset 262275), nlopess
>> removed the code from the scanner.
>>
>> Oops?
>
> What's the problem your having? The skip code is still there just in a  
> different bit.
>
> Scott
>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>