Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45486
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain macvicar.net from 97.107.131.220 cause and error)
References: <20090904081640.GA28685@joeysmith.com>
Message-ID: <753B9AED-C850-4EBA-A828-93A2542F81A2@macvicar.net>
To: Joey Smith <joey@joeysmith.com>
In-Reply-To: <20090904081640.GA28685@joeysmith.com>
Content-Type: text/plain;
	charset=us-ascii;
	format=flowed;
	delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (iPhone Mail 7A341)
Date: Fri, 4 Sep 2009 09:25:52 +0100
Cc: "internals@lists.php.net" <internals@lists.php.net>
Subject: Re: [PHP-DEV] shebang skipping in 5.3.0
From: scott@macvicar.net (Scott MacVicar)



On 4 Sep 2009, at 09:16, Joey Smith <joey@joeysmith.com> wrote:

> I can understand not having the 'shebang skipping' code
> in both the SAPI *and* the scanner, but we probably
> need to have it in at least ONE of them. :)
>
> Per his email[1] almost a year ago, Dmitry removed the
> shebang line check from sapi/cgi/cgi_main.c in changeset
> 264153, saying:
>    Removed shebang line check from CGI sapi (it is
>        checked by scanner)
>
> In http://tinyurl.com/me8528 (changeset 262275), nlopess
> removed the code from the scanner.
>
> Oops?

What's the problem your having? The skip code is still there just in a  
different bit.

Scott