Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45484 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96473 invoked from network); 4 Sep 2009 08:16:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Sep 2009 08:16:26 -0000 Authentication-Results: pb1.pair.com smtp.mail=joey@joeysmith.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=joey@joeysmith.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain joeysmith.com designates 209.90.98.146 as permitted sender) X-PHP-List-Original-Sender: joey@joeysmith.com X-Host-Fingerprint: 209.90.98.146 host-3.pl1071314.fiber.net Received: from [209.90.98.146] ([209.90.98.146:37954] helo=joeysmith.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EA/84-00514-8DCC0AA4 for ; Fri, 04 Sep 2009 04:16:25 -0400 Received: from joey by joeysmith.com with local (Exim 4.69) (envelope-from ) id 1MjTyK-0004jZ-Oq for internals@lists.php.net; Fri, 04 Sep 2009 02:16:40 -0600 Date: Fri, 4 Sep 2009 02:16:40 -0600 To: internals@lists.php.net Message-ID: <20090904081640.GA28685@joeysmith.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Subject: shebang skipping in 5.3.0 From: joey@joeysmith.com (Joey Smith) I can understand not having the 'shebang skipping' code in both the SAPI *and* the scanner, but we probably need to have it in at least ONE of them. :) Per his email[1] almost a year ago, Dmitry removed the shebang line check from sapi/cgi/cgi_main.c in changeset 264153, saying: Removed shebang line check from CGI sapi (it is checked by scanner) In http://tinyurl.com/me8528 (changeset 262275), nlopess removed the code from the scanner. Oops?