Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45482 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57820 invoked from network); 4 Sep 2009 00:41:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Sep 2009 00:41:02 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Linux 2.4/2.6 Received: from [63.205.162.117] ([63.205.162.117:53515] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1C/30-56021-D1260AA4 for ; Thu, 03 Sep 2009 20:41:01 -0400 Received: from us-gw1.zend.com (us-ex1.zend.net [192.168.16.5]) by us-mr1.zend.com (Postfix) with ESMTP id E2511E1240; Thu, 3 Sep 2009 17:27:55 -0700 (PDT) Received: from [192.168.16.83] ([192.168.16.83]) by us-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 3 Sep 2009 17:31:09 -0700 Message-ID: <4AA05FCC.2000501@zend.com> Date: Thu, 03 Sep 2009 17:31:08 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Garrett Serack CC: 'PHP Internals' References: <4A9EE046.4090500@zend.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 04 Sep 2009 00:31:09.0055 (UTC) FILETIME=[FF50E8F0:01CA2CF6] Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly) From: stas@zend.com (Stanislav Malyshev) Hi! > it happens on Linux and Windows. I've repro'd it in both places. > > The bug submitter hadn't tested elsewhere. You are right. However, I notice something strange with your patch - if I call stream_get_line again with the same parameters I get "". Shouldn't I get false instead, as it's at EOF? fgets() returns false. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com