Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45479 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37580 invoked from network); 3 Sep 2009 21:26:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Sep 2009 21:26:40 -0000 Authentication-Results: pb1.pair.com smtp.mail=garretts@microsoft.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=garretts@microsoft.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain microsoft.com designates 131.107.115.214 as permitted sender) X-PHP-List-Original-Sender: garretts@microsoft.com X-Host-Fingerprint: 131.107.115.214 smtp.microsoft.com Received: from [131.107.115.214] ([131.107.115.214:18985] helo=smtp.microsoft.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 23/1F-19451-C8430AA4 for ; Thu, 03 Sep 2009 17:26:38 -0400 Received: from TK5EX14MLTC101.redmond.corp.microsoft.com (157.54.79.178) by TK5-EXGWY-E803.partners.extranet.microsoft.com (10.251.56.169) with Microsoft SMTP Server (TLS) id 8.2.176.0; Thu, 3 Sep 2009 14:26:33 -0700 Received: from TK5EX14MBXC127.redmond.corp.microsoft.com ([169.254.6.236]) by TK5EX14MLTC101.redmond.corp.microsoft.com ([157.54.79.178]) with mapi; Thu, 3 Sep 2009 14:26:32 -0700 To: Pierre Joye CC: =?iso-8859-1?Q?Hans_=C5hlin?= , "internals@lists.php.net" Thread-Topic: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly) Thread-Index: AQHKLFeaflnFil+xK0ucvYhc1Q54wZDFJA7ggAAuaHCAAAGYUIAAgBCA//+NicA= Date: Thu, 3 Sep 2009 21:26:31 +0000 Message-ID: References: <4A9EE046.4090500@zend.com> <72e33a530909022226u319b15fbt62cdd53648f1dbd3@mail.gmail.com> <72e33a530909022229l72ffa77cx7f7b6981d08a41a1@mail.gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly) From: garretts@microsoft.com (Garrett Serack) I'll have to wait till next week to write those. No Problem. G -----Original Message----- From: Pierre Joye [mailto:pierre.php@gmail.com]=20 Sent: Thursday, September 03, 2009 2:16 PM To: Garrett Serack Cc: Hans =C5hlin; internals@lists.php.net Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fs= eek does not work correctly) hi Garrett, As the patch looks simple I still like to have a bunch set of other tests before applying it (especially for 5.2/3). The tests should ideally use various stream backends (user, bz, etc.). Cheers, On Thu, Sep 3, 2009 at 10:38 PM, Garrett Serack wro= te: > Ah, no. That is correctly handled. (the default max line length is 8k), a= nd passing in a larger number works just fine. > > G > -----Original Message----- > From: Garrett Serack > Sent: Thursday, September 03, 2009 1:32 PM > To: Garrett Serack; Hans =C5hlin; internals@lists.php.net > Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and = fseek does not work correctly) > > Ah, I found another case... when the line length is longer than the read = buffer. I'll post again in a few minutes. > > G > > -----Original Message----- > From: Garrett Serack [mailto:garretts@microsoft.com] > Sent: Thursday, September 03, 2009 1:22 PM > To: Hans =C5hlin; internals@lists.php.net > Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and = fseek does not work correctly) > > Without the patch, That is what will you see (windows or linux). (Which i= s wrong...) > > The patch corrects the case where the stream has been fseek'd to the last= line in the file, when the last line doesn't end with a line terminator. (= where you see 'false' in the results). > > Without the patch, the code mistakenly checks for EOF *after* characters = have been read in, which is completely unnecessary (and incorrect) since th= e read operation has taken place already. > > There could be some question as to the proper behavior when the stream *i= s* at EOF, and stream_get_line is called (return NULL or empty string), but= the behavior previously was to return the empty string (keep calling strea= m_get_line and once you reach the end, you will just get empty strings). > > G > > -----Original Message----- > From: ahlin.hans@gmail.com [mailto:ahlin.hans@gmail.com] On Behalf Of Han= s =C5hlin > Sent: Wednesday, September 02, 2009 10:29 PM > To: internals@lists.php.net > Subject: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fsee= k does not work correctly) > > I just ran the test on Linux 2.6.29 FC11 Apache 2.2.13 and PHP 5.2.9 > > Result: > > string 'line1' (length=3D5) > string '' (length=3D0) > string 'line1' (length=3D5) > string '' (length=3D0) > string 'line1' (length=3D5) > string 'line2' (length=3D5) > string 'line1' (length=3D5) > boolean false > string 'line1' (length=3D5) > string 'line2' (length=3D5) > string 'line1' (length=3D5) > string 'line2' (length=3D5) > > -- > MvH / Hans =C5hlin > Tel: +46761488019 > http//www.kronan-net.com/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > > --=20 Pierre http://blog.thepimp.net | http://www.libgd.org --=20 PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php