Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45452 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70862 invoked from network); 2 Sep 2009 21:30:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2009 21:30:04 -0000 Authentication-Results: pb1.pair.com header.from=garretts@microsoft.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=garretts@microsoft.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain microsoft.com designates 131.107.115.215 as permitted sender) X-PHP-List-Original-Sender: garretts@microsoft.com X-Host-Fingerprint: 131.107.115.215 mail2.microsoft.com Received: from [131.107.115.215] ([131.107.115.215:45074] helo=smtp.microsoft.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DB/B2-56016-BD3EE9A4 for ; Wed, 02 Sep 2009 17:30:04 -0400 Received: from TK5EX14HUBC101.redmond.corp.microsoft.com (157.54.7.153) by TK5-EXGWY-E802.partners.extranet.microsoft.com (10.251.56.168) with Microsoft SMTP Server (TLS) id 8.2.176.0; Wed, 2 Sep 2009 14:30:01 -0700 Received: from TK5EX14MBXC127.redmond.corp.microsoft.com ([169.254.6.236]) by TK5EX14HUBC101.redmond.corp.microsoft.com ([157.54.7.153]) with mapi; Wed, 2 Sep 2009 14:30:00 -0700 To: Stanislav Malyshev CC: 'PHP Internals' Thread-Topic: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly) Thread-Index: AQHKLBReRR5UABK2xkOGr9gfVRgblpDD0KoA Date: Wed, 2 Sep 2009 21:29:58 +0000 Message-ID: References: <4A9EE046.4090500@zend.com> In-Reply-To: <4A9EE046.4090500@zend.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly) From: garretts@microsoft.com (Garrett Serack) it happens on Linux and Windows. I've repro'd it in both places. The bug submitter hadn't tested elsewhere. G -----Original Message----- From: Stanislav Malyshev [mailto:stas@zend.com]=20 Sent: Wednesday, September 02, 2009 2:15 PM To: Garrett Serack Cc: 'PHP Internals' Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fs= eek does not work correctly) Hi! > I thought I'd run this by folks first before committing, as it=20 > impacts streams, which are pretty important :D . It passes the=20 > current tests, and I wrote test for it too. (below). I notice that the bug says it happens only on Windows, while the fix doesn't have anything specific for windows. Could you explain why it is so? Another question is why stream->eof is not set in this case on Windows - shouldn't it be? --=20 Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com --=20 PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php