Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45451 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69543 invoked from network); 2 Sep 2009 21:28:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2009 21:28:00 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Linux 2.4/2.6 Received: from [63.205.162.117] ([63.205.162.117:52980] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 60/72-56016-E53EE9A4 for ; Wed, 02 Sep 2009 17:27:59 -0400 Received: from us-gw1.zend.com (us-ex1.zend.net [192.168.16.5]) by us-mr1.zend.com (Postfix) with ESMTP id 9B186E11EA; Wed, 2 Sep 2009 14:14:54 -0700 (PDT) Received: from [192.168.16.83] ([192.168.16.83]) by us-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 2 Sep 2009 14:14:46 -0700 Message-ID: <4A9EE046.4090500@zend.com> Date: Wed, 02 Sep 2009 14:14:46 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Garrett Serack CC: 'PHP Internals' References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Sep 2009 21:14:47.0009 (UTC) FILETIME=[66419D10:01CA2C12] Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly) From: stas@zend.com (Stanislav Malyshev) Hi! > I thought I'd run this by folks first before committing, as it > impacts streams, which are pretty important :D . It passes the > current tests, and I wrote test for it too. (below). I notice that the bug says it happens only on Windows, while the fix doesn't have anything specific for windows. Could you explain why it is so? Another question is why stream->eof is not set in this case on Windows - shouldn't it be? -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com