Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45418 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57638 invoked from network); 27 Aug 2009 09:11:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Aug 2009 09:11:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=patrick.allaert@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=patrick.allaert@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.212 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: patrick.allaert@gmail.com X-Host-Fingerprint: 209.85.220.212 mail-fx0-f212.google.com Received: from [209.85.220.212] ([209.85.220.212:58344] helo=mail-fx0-f212.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C5/3C-09105-5BD469A4 for ; Thu, 27 Aug 2009 05:11:17 -0400 Received: by fxm8 with SMTP id 8so782784fxm.23 for ; Thu, 27 Aug 2009 02:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=7j+/zjnDA1192DHy4rgd62fHOa7i3kVm+v2Wgc6QxY8=; b=pLAjLbxpHC7Tcil9id2ehc1qPY46YviTBGLzGHbAEZULoW4HTUExkSXfOmSfNYEFwT J5SSpGbqLhPG+zVl6g1OEBvM7QYqaYZdZ2jVjUkx1c9GfZtfbsbf45jzuLB5awpSlwqu EtODHYUXtIhCCyXb4kYptDz47BssIwN9aRwsU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; b=cDnzDfzBynSBZhYmivyK3RRS1DxH77krrDGltPOok24IJ8JYyGagqxC5azYzrkbo9i SEbKlJVV31WmQIT1oY5SzRpDT3ZTJlGlQ5og0JjMqfNeBm5uhJfSWa1NJX6CdK/GHmKS aIXiXuOZKv8BKFCCfRCNN4Q0dc4UdKI/876gs= MIME-Version: 1.0 Sender: patrick.allaert@gmail.com Received: by 10.204.156.213 with SMTP id y21mr3461570bkw.109.1251364274435; Thu, 27 Aug 2009 02:11:14 -0700 (PDT) Date: Thu, 27 Aug 2009 11:11:14 +0200 X-Google-Sender-Auth: b456d1131834566c Message-ID: To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= Cc: PHP Development Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Dead code [PATCH] From: patrickallaert@php.net (Patrick ALLAERT) 2009/8/25 Johannes Schl=C3=BCter : [snip] > For 6 I assume one might remove it, especially as it doesn't know about > IS_UNICODE. I thought I had enough karma to do it myself. Can someone make it in trunk then? Index: ext/standard/math.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- ext/standard/math.c (revision 287794) +++ ext/standard/math.c (working copy) @@ -795,51 +795,6 @@ } /* }}} */ -/* {{{ _php_math_basetolong */ -/* - * Convert a string representation of a base(2-36) number to a long. - */ -PHPAPI long _php_math_basetolong(zval *arg, int base) -{ - long num =3D 0, digit, onum; - int i; - char c, *s; - - if (Z_TYPE_P(arg) !=3D IS_STRING || base < 2 || base > 36) { - return 0; - } - - s =3D Z_STRVAL_P(arg); - - for (i =3D Z_STRLEN_P(arg); i > 0; i--) { - c =3D *s++; - - digit =3D (c >=3D '0' && c <=3D '9') ? c - '0' - : (c >=3D 'A' && c <=3D 'Z') ? c - 'A' + 10 - : (c >=3D 'a' && c <=3D 'z') ? c - 'a' + 10 - : base; - - if (digit >=3D base) { - continue; - } - - onum =3D num; - num =3D num * base + digit; - if (num > onum) - continue; - - { - TSRMLS_FETCH(); - - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Number '%s' is too big to fit in long", s); - return LONG_MAX; - } - } - - return num; -} -/* }}} */ - /* {{{ _php_math_basetozval */ /* * Convert a string representation of a base(2-36) number to a zval. --=20 Patrick Allaert --- http://code.google.com/p/peclapm/ - Alternative PHP Monitor