Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45407 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5983 invoked from network); 25 Aug 2009 21:52:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Aug 2009 21:52:09 -0000 Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 83.243.58.134 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 83.243.58.134 mailout2.netbeat.de Linux 2.6 Received: from [83.243.58.134] ([83.243.58.134:58141] helo=mailout2.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/88-00335-50D549A4 for ; Tue, 25 Aug 2009 17:52:07 -0400 Received: (qmail 2255 invoked by uid 89); 25 Aug 2009 22:31:50 -0000 Received: from unknown (HELO ?192.168.1.111?) (postmaster%schlueters.de@88.217.55.201) by mailout2.netbeat.de with ESMTPA; 25 Aug 2009 22:31:50 -0000 To: Patrick ALLAERT Cc: PHP Development In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Tue, 25 Aug 2009 23:51:34 +0200 Message-ID: <1251237094.1786.2.camel@guybrush> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Dead code From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, even if no known extension uses it I won't remove it in 5.3 as it is a break of ABI compatibility. For 6 I assume one might remove it, especially as it doesn't know about IS_UNICODE. johannes On Mon, 2009-08-24 at 08:24 +0200, Patrick ALLAERT wrote: > Hi list, > > Apparently, function _php_math_basetolong at > http://lxr.php.net/source/php-src/ext/standard/math.c#802 > isn't used anymore since Mon Sep 3 16:26:31 2001 UTC. > > It was previously used by bindec, hexdec, octdec and base_convert > functions but has been replaced by _php_math_basetozval(). > > None of the PECL extension are using it either (at least in > http://svn.php.net/repository/pecl/*/trunk/). > > Any objection I remove it? > > -- > Patrick > --- > http://code.google.com/p/peclapm/ - Alternative PHP Monitor >