Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45392 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39306 invoked from network); 25 Aug 2009 12:49:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Aug 2009 12:49:16 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.94.239.7 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.94.239.7 mail.jdi.nl Received: from [82.94.239.7] ([82.94.239.7:56506] helo=mail.jdi-ict.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 75/63-22580-8CDD39A4 for ; Tue, 25 Aug 2009 08:49:15 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id n7PCn89X003202; Tue, 25 Aug 2009 14:49:08 +0200 X-Virus-Scanned: by amavisd-new at jdi-ict.nl Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id n7PCmh08003052; Tue, 25 Aug 2009 14:49:05 +0200 Date: Tue, 25 Aug 2009 13:48:43 +0100 (BST) X-X-Sender: derick@kossu.ez.no To: Stanislav Malyshev cc: Ilia Alshanetsky , Greg Beaver , "'PHP Internals'" In-Reply-To: <4A938706.8060600@zend.com> Message-ID: References: <4A92D936.2010107@zend.com> <4A931A1C.804@chiaraquartet.net> <39F20BFC-DAA0-4403-A52E-62CE5F4CF0FE@prohost.org> <4A9346CA.3070608@chiaraquartet.net> <4B0E7BED-C2AE-4BE5-B6CA-00B810168961@prohost.org> <4A938706.8060600@zend.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2 (jdi.jdi-ict.nl [127.0.0.1]); Tue, 25 Aug 2009 14:49:05 +0200 (CEST) Subject: Re: [PHP-DEV] Re: [patch] error masks From: derick@php.net (Derick Rethans) On Mon, 24 Aug 2009, Stanislav Malyshev wrote: > > If you enable error log you would be able to identify errors, even > > in legacy code fairly quickly and address them as needed. The speed > > increase, by Stas' own admission is very minimal here, I would wager > > It's not "very minimal". It's not big overall, but it speeds up > operations affected 300-400%. Can you propose many other changes that > would speed up any set of opcodes 300% in 10 lines of patch? ;) Considering that there shouldn't be any errors in the first place, this is of course a moot point. Sure, 3rd party code (PEAR pcakges?) might throw errors like crazy on PHP 5, they need to be *fixed* anyway. So if the minimal overhead of the *whole* application is not close to affected... I think it'd be a very bad idea to add this extra mask. Yet another ini setting as well. For the record: I'm against adding this. regards, Derick -- http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org twitter: @derickr