Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45389 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67655 invoked from network); 25 Aug 2009 08:37:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Aug 2009 08:37:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=rquadling@googlemail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=rquadling@googlemail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.220.212 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: rquadling@googlemail.com X-Host-Fingerprint: 209.85.220.212 mail-fx0-f212.google.com Received: from [209.85.220.212] ([209.85.220.212:32809] helo=mail-fx0-f212.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5A/10-01215-BD2A39A4 for ; Tue, 25 Aug 2009 04:37:48 -0400 Received: by fxm8 with SMTP id 8so1826207fxm.23 for ; Tue, 25 Aug 2009 01:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:reply-to:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=bmgY7GjzEH7u/AywPuUrUwB2sC1xVnVf0prgnsLQR9A=; b=bl0RKiGWXeKMQX6xXIo8B78vw30XRH4P8JEKnrTGf43s81c13iIILtQBMmrKtcO/iM W/Bna/fct2rvr53rfvWv99/r17hOsZKv8I5OKtMD/mveidN4rtcHZV7Em2uFqK5XV6rw t1xoejg9q6o/4qeWYFfnTgiTQjZHLOHvOXU8o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; b=seKmct872CZTYJc5MSTAun86tESoUZOiyoPTLP3dDtNR6Tr2YrqRXZoMsMaHXg7VNr 3/ygUQ12GpGs5JKSd41puSPEetCszVQ7oHHKh6Xpn9/apoVbPTHSUVID4FvkyYg0EddL p/7dbhmsC56/fLIt9Vvr4hSBRGewqPtaWlAyo= MIME-Version: 1.0 Received: by 10.223.4.216 with SMTP id 24mr5272733fas.67.1251189465098; Tue, 25 Aug 2009 01:37:45 -0700 (PDT) Reply-To: RQuadling@googlemail.com In-Reply-To: <4A9308F3.3050004@lerdorf.com> References: <4A92D936.2010107@zend.com> <4A92DC60.2050606@zend.com> <4A92EA60.6020605@zend.com> <4A92F13B.9000204@zend.com> <4A92FFA8.1060401@zend.com> <4A9304FC.2000906@sci.fi> <4A9308F3.3050004@lerdorf.com> Date: Tue, 25 Aug 2009 09:37:25 +0100 Message-ID: <10845a340908250137p117d6a28tb8ecb4ba4def44a4@mail.gmail.com> To: Rasmus Lerdorf Cc: jani.taskinen@iki.fi, Stanislav Malyshev , Ilia Alshanetsky , PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [patch] error masks From: rquadling@googlemail.com (Richard Quadling) 2009/8/24 Rasmus Lerdorf : > I think we should do something along the lines of what Stas is > suggesting. =C2=A0The current approach of allocating and sprintf'ing all > messages regardless of whether they will ever be used for anything is > painful and a huge impediment to adding informative E_NOTICE and > E_STRICT messages in the future. > > A good example of the benefit of this patch is upgrading a server > running older PHP code that causes a lot of E_STRICT messages. =C2=A0The > performance hit can be significant to the point where people may > downgrade to the older version until they can get around to cleaning up > the code. =C2=A0Having the ability to properly turn off E_STRICT such tha= t > not only are E_STRICT messages not shown, but they also don't eat up > valuable cpu cycles is something we should have done long ago. =C2=A0It i= s > non-intuitive that disabling an error type doesn't also remove the > performance hit associated with generating that error message. > > -Rasmus > As an outsider, and from what I've read here, surely the solution is to simply move the test to determine if an error type is reportable. If anything, as you _ARE_ all saying that there is a slowdown, I should maybe file a bug ... "My @ridden code is really slow, even when I turn off error_reporting!" So, as an outsider, I'm +1 for speeding up PHP by not running unnecessary code, but -1 for introducing what is surely quite obviously an unnecessary ini entry. Essentially, it's a bug folks! So let's fix it! Regards, Richard. --=20 ----- Richard Quadling "Standing on the shoulders of some very clever giants!" EE : http://www.experts-exchange.com/M_248814.html Zend Certified Engineer : http://zend.com/zce.php?c=3DZEND002498&r=3D213474= 731 ZOPA : http://uk.zopa.com/member/RQuadling