Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45382 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18904 invoked from network); 25 Aug 2009 03:09:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Aug 2009 03:09:29 -0000 Authentication-Results: pb1.pair.com header.from=danielc@analysisandsolutions.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=danielc@analysisandsolutions.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain analysisandsolutions.com from 166.84.1.72 cause and error) X-PHP-List-Original-Sender: danielc@analysisandsolutions.com X-Host-Fingerprint: 166.84.1.72 mail1.panix.com Received: from [166.84.1.72] ([166.84.1.72:51919] helo=mail1.panix.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id ED/02-08544-8E5539A4 for ; Mon, 24 Aug 2009 23:09:29 -0400 Received: from panix5.panix.com (panix5.panix.com [166.84.1.5]) by mail1.panix.com (Postfix) with ESMTP id E07661F085 for ; Mon, 24 Aug 2009 23:09:25 -0400 (EDT) Received: by panix5.panix.com (Postfix, from userid 14662) id CABF324207; Mon, 24 Aug 2009 23:09:25 -0400 (EDT) Date: Mon, 24 Aug 2009 23:09:25 -0400 To: PHP Internals List Message-ID: <20090825030925.GA21165@panix.com> References: <4A92D936.2010107@zend.com> <9E8BD3A3-8915-4492-88A9-7EA1A0CF6D86@prohost.org> <4A92DC60.2050606@zend.com> <4A92EA60.6020605@zend.com> <4A92F13B.9000204@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A92F13B.9000204@zend.com> User-Agent: Mutt/1.5.18 (2008-05-17) Subject: Re: [PHP-DEV] [patch] error masks From: danielc@analysisandsolutions.com (Daniel Convissor) Hi Stas: On Mon, Aug 24, 2009 at 12:59:55PM -0700, Stanislav Malyshev wrote: > > Just search for @fopen or @include or > @xml or @eval - tons of examples. True. But this patch could cause problems. @ is often used to stop error/warning output to the browser on that line, but the next couple lines of code are used to handle that error. For example: if (!($dom = @DOMDocument::load($file_name))) { log_it('invalid XML: ' . $php_errormsg); die('invalid XML'); } So if error processing is totally turned off, $php_errormsg won't be populated. I like the general idea, but I'm encouraging folks to carefully consider the ramifications of various implementation methods. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409