Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45380
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 209.85.222.174 cause and error)
Message-ID: <4A9346CA.3070608@chiaraquartet.net>
Date: Mon, 24 Aug 2009 21:04:58 -0500
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070807)
MIME-Version: 1.0
To: Ilia Alshanetsky <ilia@prohost.org>
CC: Stanislav Malyshev <stas@zend.com>, 
 'PHP Internals' <internals@lists.php.net>
References: <4A92D936.2010107@zend.com> <4A931A1C.804@chiaraquartet.net> <39F20BFC-DAA0-4403-A52E-62CE5F4CF0FE@prohost.org>
In-Reply-To: <39F20BFC-DAA0-4403-A52E-62CE5F4CF0FE@prohost.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [patch] error masks
From: greg@chiaraquartet.net (Greg Beaver)

Ilia Alshanetsky wrote:
> 
> On 24-Aug-09, at 6:54 PM, Greg Beaver wrote:
>>
>> 2) as long as the patch does not break any backwards compatibility
>> (error logging still works as it always did independent of error_mask,
>> user error handlers still get the same stuff), why would we care?  There
>> is a time and place for being academic about fixing things and it is
>> called development, not production.
> 
> You must not have any bugs in production environment, I am very envious.
> :-)

Ilia,

I don't see how this kind of emotional hyperbole contributes positively
to the discussion.

If I understand you right, you're arguing that people should never use
code in production that emits errors.  That is certainly the goal.  It's
also not always possible to do this when relying upon third-party code
which may have been written for a pre-E_STRICT or a pre-E_DEPRECATED php
version.

What I don't understand is why you think this:

<?php
error_reporting(E_WARNING|E_ERROR|E_NOTICE|E_USER_WARNING|E_USER_ERROR|E_USER_NOTICE);
class A
{
// emits an E_STRICT normally, and we waste cycles emitting an E_STRICT
that is never emitted
    function A(){}
}
?>

is better than:

<?php
ini_set('error_mask',
E_WARNING|E_ERROR|E_NOTICE|E_USER_WARNING|E_USER_ERROR|E_USER_NOTICE);
class A
{
// just works (TM) as fast as it did in PHP 4
    function A(){}
}
?>

IF (and a big if) no user error handler is in place, which should pass
all possible errors into the error handler.

If your fear is that third party people might do something horrendous like:

<?php
ini_set('error_mask', 0);
stupidfatalerror();
?>

That's also easily solved by making it INI_SYSTEM.

Greg