Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45365
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.157 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=cBb+bXANjfS9+mCG0s+2epnRrFHTNgE6s1GSmrugf+zmyZiE1AeODsYDfn+L5R0Ev8
         5w8EEff4/q3oqoLTpL70m+C5K6D/j6+FLN2NkyHsd941OIEFhKVvzvDIXHJ6j3QsqEi7
         dy8eDdW3rHHkhAg60k7l+5BHrnrZt3aMAvHO4=
MIME-Version: 1.0
In-Reply-To: <250F0E93-D6F2-490F-9129-598AC6E96500@pooteeweet.org>
References: <4A92D936.2010107@zend.com>
	 <BE47C3D9-A9FA-45CD-A004-79C8479AFDD3@prohost.org>
	 <4A92EA60.6020605@zend.com>
	 <D3312479-4C3C-4F95-8503-FA0633FF835E@prohost.org>
	 <4A92F13B.9000204@zend.com>
	 <CCC293B8-52C8-4473-8027-6F7B32DC0C3F@prohost.org>
	 <4A92FFA8.1060401@zend.com> <4A9304FC.2000906@sci.fi>
	 <4A930956.9070709@zend.com>
	 <250F0E93-D6F2-490F-9129-598AC6E96500@pooteeweet.org>
Date: Tue, 25 Aug 2009 00:08:07 +0200
Message-ID: <fe05d1540908241508n741cebcdo69439dc2a987a0d0@mail.gmail.com>
To: Lukas Kahwe Smith <mls@pooteeweet.org>
Cc: Stanislav Malyshev <stas@zend.com>, jani.taskinen@iki.fi, 
	Ilia Alshanetsky <ilia@prohost.org>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [patch] error masks
From: pierre.php@gmail.com (Pierre Joye)

hi Lukas,

On Mon, Aug 24, 2009 at 11:51 PM, Lukas Kahwe Smith<mls@pooteeweet.org> wrote:
>
> On 24.08.2009, at 23:42, Stanislav Malyshev wrote:
>
>> Hi!
>>
>>> Quite boring to read this thread where two persons argue about something
>>> abstract. Stas, can you give a real life example where your patch is
>>> necessary..?
>>
>> Any code where you either use @ or error_reporting which is not -1 would
>> benefit from it by not processing errors that go nowhere. I just looked at
>> Zend Framework - with is pretty clean with regard to E_NOTICE/E_STRICT
>> problems - and @ is used in dozens of classes around. The speedup would be
>> probably not very big for whole RL application, but it's a 10-line patch,
>> and little things help too.
>
>
> well a few of those places would probably be fixable, by providing functions
> to check beforehand if calling the final function would cause an error. but
> that if course would add more overhead, but would still be the "cleaner"
> solution.

To call a function to avoid a noisy or resource expensive error is just as bad.

There are many common operations in PHP where we over react (file ops
for example). As I agree with Rasmus' comments, I do think that this
patch is the wrong fix for the real problem (that does not mean I do
not like to have it in). I would however prefer to have APIs without
any kind of noisy errors, at least for the common operations or where
the error is obviously expected (as IO can fail). Please note that I
did not suggest to use exceptions everywhere.

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org