Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45246 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81626 invoked from network); 7 Aug 2009 20:09:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Aug 2009 20:09:14 -0000 Authentication-Results: pb1.pair.com header.from=david.zuelke@bitextender.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=david.zuelke@bitextender.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain bitextender.com from 80.237.132.12 cause and error) X-PHP-List-Original-Sender: david.zuelke@bitextender.com X-Host-Fingerprint: 80.237.132.12 wp005.webpack.hosteurope.de Received: from [80.237.132.12] ([80.237.132.12:59700] helo=wp005.webpack.hosteurope.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 47/9D-08634-9E98C7A4 for ; Fri, 07 Aug 2009 16:09:14 -0400 Received: from dslb-088-064-059-059.pools.arcor-ip.net ([88.64.59.59] helo=[192.168.0.101]); authenticated by wp005.webpack.hosteurope.de running ExIM with esmtpsa (TLSv1:RC4-SHA:128) id 1MZVkU-0006qY-KR; Fri, 07 Aug 2009 22:09:10 +0200 Message-ID: <26A36234-0C04-40A5-BDC0-42AF7C49354B@bitextender.com> To: php-dev List In-Reply-To: <4A6F3211.40801@sci.fi> Content-Type: multipart/signed; boundary=Apple-Mail-2-785610581; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v936) Date: Fri, 7 Aug 2009 22:09:10 +0200 References: <67DEF003-A344-4BE6-9C23-6BB48935786F@bitextender.com> <4A6EE1BF.8080409@zend.com> <4A6F027B.3040608@zend.com> <4A6F3211.40801@sci.fi> X-Mailer: Apple Mail (2.936) X-bounce-key: webpack.hosteurope.de;david.zuelke@bitextender.com;1249675754;98bea591; Subject: Re: [PHP-DEV] Re: SOAP_MARSHAL_DATETIME (or: bug #44383) From: david.zuelke@bitextender.com (=?ISO-8859-1?Q?David_Z=FClke?=) --Apple-Mail-2-785610581 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable On 28.07.2009, at 19:14, Jani Taskinen wrote: > Dmitry Stogov wrote: >> David Z=FClke wrote: >>> On 28.07.2009, at 13:32, Dmitry Stogov wrote: >>> >>>> Hi David, >>>> >>>> I took only a quick look, but I like the patch. >>>> In case it doesn't break any tests, it should be committed at =20 >>>> least into >>>> HEAD. I agree to commit it into 5.3 too, but RMs take the final =20 >>>> decision. >>>> >>>> The only thing I didn't understood - why win32/php_stdint.h is =20 >>>> needed. >>> Ah, yes, that's probably an oversight. Good catch. The headers were >>> copy-pasted from some ext/date file :) >>> >>> Another thing that just occured to me is that we now have a =20 >>> dependency >>> on ext/date; I think I had trouble compiling ext/soap as a =20 >>> standalone >>> extension like this. Must check again. Any hints? >> I think ext/date can't be removed or compiled as shared extension. >> If it's the case, the only problem may be with unexported symbols. >> Just try to compile/test it as shared extension on Linux and Windows. > > ext/date is not an extension, it's part of core, just like ext/=20 > standard so you shouldn't have any problems with it. Not attached (because the draconian police state filters at =20 lists.php.net didn't like the patch attachment or something :)), but =20 posted here: http://pastie.org/575559 and here: = http://bugs.php.net/44383=20 , is an update of the patch. It has the following updates: 1) all tests adjusted, reviewed and changed to work in sequence (only =20= one of the several variants was not commented out before) 2) fixed handling of unix timestamp longs There are the following outstanding issues (I'm going on a holiday =20 tomorrow, so I figured I'd shoot you an update in the meantime): First, there seem to be problems with negative timezone offsets (see =20 tests ext/soap/tests/schema/schema0(89|91).phpt) unless I'm confused Second, at the minute, it breaks ext/soap/tests/schema/schema064.phpt. =20= Except for one of the cases where the formatting is indeed wrong, it's =20= due to time zones not being included. That obviously needs fixing, but I'd like to point out that the =20 current tests do not seem to be in compliance with the XML Schema =20 specification, which for gMonthDay, gDay and gMonth states: "An =20 optional following time zone qualifier is allowed as for date". The rule for "date" and timezone postfixes is "For timezoned values, =20 append the canonical representation of the =B7recoverable timezone=B7". = A =20 recoverable timezone is an offset value in the format "[+-]hh:mm". = http://www.w3.org/TR/xmlschema-2/=20 has all the details, but maybe I'm missing something. For gYearMonth and gYear, I think the "dateTime" timezone rules apply, =20= which means the canonical representation must always be in UTC (and =20 thus carry "Z" as the timezone identifier, which is what the tests =20 currently expect, so those are correct). Finally, when I compile as an extension, I get the following error =20 once I reach tests that execute code relying on timelib: > dyld: lazy symbol binding failed: Symbol not found: _timelib_time_ctor > Referenced from: .../extensions/no-debug-non-zts-20090626/soap.so > Expected in: flat namespace > > dyld: Symbol not found: _timelib_time_ctor > Referenced from: .../extensions/no-debug-non-zts-20090626/soap.so > Expected in: flat namespace I compiled without --enable-soap, then used the correct "phpize" in =20 ext/soap, ran configure with the correct --with-php-config=3D.../blah/=20= php-config, make install and enabled the extension in php.ini. Feedback/thoughts/advice appreciated. I'll be back in ~2 weeks. Cheers, - David --Apple-Mail-2-785610581 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGXDCCAxUw ggJ+oAMCAQICEHvgrI6DXM4XmK4XvhB7lh4wDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MDgyMjE0MjEzOVoXDTA5MDgyMjE0MjEz OVowTjEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjErMCkGCSqGSIb3DQEJARYcZGF2 aWQuenVlbGtlQGJpdGV4dGVuZGVyLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEB ANx+fe+8oUaO+fotZryRBmD3NAP00QikUIqIyZKiwJ4BS9M8DdqN0lAh443rdw1h/H0NVkDMv7+7 MnSUYKU+BTwulvU7WDGLm7JGkXXWkGl5vHUnUWltUkk8ImUDiunYPnuyUVyQlnZkp1ThihYoR4xo MmiiC+6mHLl8FzMKimOU/UREpGfyLqYhsNdXiVgm+W8feO6aY3fDaenn9EVZEXJs6t7KxLpCIlD2 8+0dHlX+91vV4a9zfMObjEkLW3w/uBTT+uHypySHo/EWw0/pOD34sMdhSh0Xyr4un+Uv/DHH1ft3 5TJq6DEIrIL4iUpGa7Nsqjoah5SgpWwJY+gWaC8CAwEAAaNcMFowDgYDVR0PAQH/BAQDAgSwMBEG CWCGSAGG+EIBAQQEAwIFIDAnBgNVHREEIDAegRxkYXZpZC56dWVsa2VAYml0ZXh0ZW5kZXIuY29t MAwGA1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEFBQADgYEAbEPiMjevqmbl2NuGieZkF5fNV1Uhr0dL wGDDxIcIHGnBeEBVy/5NpAKJUCU4lqG+bqD1S4MdyyLxvzlhOSZEqjcEwtwXqLVsaDakYFHsRGaS DU160+1b/wlf8/OR5tof7y5MA8p6MSQHjXWOy38A71wvwFowGZPF5lY617W5mUMwggM/MIICqKAD AgECAgENMA0GCSqGSIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBD YXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYD VQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVy c29uYWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0 ZS5jb20wHhcNMDMwNzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMG A1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVz VftOucqZWh5owHUEcJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Va qj9xVsuvPAsH5/EfkTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20Txh BEAeZBlyYLf7AgMBAAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0 hjJodHRwOi8vY3JsLnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNV HQ8EBAMCAQYwKQYDVR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqG SIb3DQEBBQUAA4GBAEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCT cDz9reFhYsPZOhl+hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo0 5RAaWzVNd+NWIXiC3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTEl MCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBl cnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECEHvgrI6DXM4XmK4XvhB7lh4wCQYFKw4DAhoFAKCC AW8wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDkwODA3MjAwOTEw WjAjBgkqhkiG9w0BCQQxFgQUe/YvgjWhn2YZskcFk//ojAFP3G0wgYUGCSsGAQQBgjcQBDF4MHYw YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhB74KyOg1zOF5iuF74Q e5YeMIGHBgsqhkiG9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBD b25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJ c3N1aW5nIENBAhB74KyOg1zOF5iuF74Qe5YeMA0GCSqGSIb3DQEBAQUABIIBAEZwRg5LRcaPjDFq 49N9ugaayIJkDufa1mvzI2/8JcYvUgyZ2fHYUn+osqg/GBIpCuFsvj2sm5qCamZlcYKPul1RSutN GT63Gj0Xcy38iUhhW0GyWfPmxQnXN2fKkb/mcXW+CSYnm5hP2Qr5OUPWbDu8Lwvbm3qQjngK/Gp0 EmyYDubh0zIDkP+VrgJPv1+vneTEdeZxc9cF/46L8CKZZXcYORjb+iflFydp/NK8kc3lEDAjstCv RmbXeXDJtNl8e74ZQ/ZBX1y23V+aT848x6jclzzXlTurIg3ISU6ufk5qoMixEGk4I9Xy9qpi1ri4 7j3XaYsev1j2CoSlsPHbCFsAAAAAAAA= --Apple-Mail-2-785610581--