Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45209
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zoltak.com from 203.16.214.140 cause and error)
Message-ID: <20090804134933.vf99eu7e8so8gg4w@webmail.zoltak.com>
Date: Tue, 04 Aug 2009 13:49:33 +1000
To: Scott MacVicar <scott@macvicar.net>
Cc: jani.taskinen@iki.fi, Jani Taskinen <jani.taskinen@sci.fi>,
	internals@lists.php.net
References: <20090731101017.jcs6fiyk0sg4gcok@webmail.zoltak.com>
	<4A72A254.8030808@sci.fi> <4A7545C4.60202@zoltak.com>
	<4A75A950.6030701@sci.fi> <4A760126.9070002@lerdorf.com>
	<4A76199F.9040701@sci.fi>
	<20090803145207.l09o05kib4ow8448@webmail.zoltak.com>
	<4A76993F.5000401@sci.fi>
	<20090803215255.0vh3a3gif4wk8o0w@webmail.zoltak.com>
	<4A76D3DB.4040106@sci.fi>
	<20090803221910.mmhi8jy20o48gc00@webmail.zoltak.com>
	<4A76D997.5090008@sci.fi>
	<20090804121441.wuq024oznoc88c4o@webmail.zoltak.com>
	<374A7AD0-D3BE-4FAE-BBBF-9B08D3A613E5@macvicar.net>
In-Reply-To: <374A7AD0-D3BE-4FAE-BBBF-9B08D3A613E5@macvicar.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-1;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.1.6)
Subject: Re: [PHP-DEV] fopen_wrappers.c DOCUMENT_ROOT .htaccess error
From: daniel@zoltak.com

Quoting Scott MacVicar <scott@macvicar.net>:
>> 1. Is it safe to lookup the DOCUMENT_ROOT in fopen_wrappers. If not  
>>  is there an alternative?
>
> Not at the point the function is being executed on a fresh child start
> PHP hasn't always been fully started by the time it's doing the config
> merging. None of the SAPI variables have been imported.
>
> You might be able to use sapi_getenv("DOCUMENT_ROOT",   
> sizeof("DOCUMENT_ROOT"))

This method dosen't appear to work.

> Another solution is to skip doing you check before the SAPI is loaded :-)

If we do this then we cannot determine if the error_log is in the  
DOCUMENT_ROOT.

>> 2. Why was this working in PHP 5.2.6 but now broken in 5.2.1x?
>
> Are you sure you were using 5.2.6?  We never checked the error_log
> value until 5.2.4, it's the first version to have it.

Yes I am positive it was PHP 5.2.6 - It worked with 5.2.4 and 5.2.5 as  
well. It would be intresting to understand why it worked in these  
versions.