Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45148 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92727 invoked from network); 30 Jul 2009 16:15:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Jul 2009 16:15:35 -0000 Authentication-Results: pb1.pair.com smtp.mail=garretts@microsoft.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=garretts@microsoft.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain microsoft.com designates 131.107.115.214 as permitted sender) X-PHP-List-Original-Sender: garretts@microsoft.com X-Host-Fingerprint: 131.107.115.214 mail3.microsoft.com Received: from [131.107.115.214] ([131.107.115.214:4956] helo=smtp.microsoft.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 69/20-25953-327C17A4 for ; Thu, 30 Jul 2009 12:15:33 -0400 Received: from TK5EX14HUBC102.redmond.corp.microsoft.com (157.54.7.154) by TK5-EXGWY-E803.partners.extranet.microsoft.com (10.251.56.169) with Microsoft SMTP Server (TLS) id 8.2.99.4; Thu, 30 Jul 2009 09:15:28 -0700 Received: from TK5EX14MBXC129.redmond.corp.microsoft.com ([169.254.8.56]) by TK5EX14HUBC102.redmond.corp.microsoft.com ([157.54.7.154]) with mapi; Thu, 30 Jul 2009 09:15:28 -0700 To: "internals@lists.php.net" Thread-Topic: Changes to php_embed.c/.h break Windows build (revision 286468/bug 48911) Thread-Index: AcoRMPMwCH6ygjN8Sgi5Q7KGyk7rEw== Date: Thu, 30 Jul 2009 16:15:26 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Changes to php_embed.c/.h break Windows build (revision 286468/bug 48911) From: garretts@microsoft.com (Garrett Serack) Howdy, In response to Bug #48911(http://bugs.php.net/bug.php?id=3D48911), revision= 286468 adds SAPI_API to int php_embed_init(int argc, char **argv PTSRMLS_DC); void php_embed_shutdown(TSRMLS_D); extern sapi_module_struct php_embed_module; Which breaks building the php5embed on Windows. On Windows, php5embed is built as a static library, and doesn't need these = functions to be marked as SAPI_API. Can I suggest we instead use "EMBED_SAPI_API" and insert : #ifndef PHP_WIN32 #define EMBED_SAPI_API SAPI_API #else #define EMBED_SAPI_API #endif Garrett