Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:45119
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender)
Message-ID: <4A6EE1BF.8080409@zend.com>
Date: Tue, 28 Jul 2009 15:32:15 +0400
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?David_Z=FClke?= <david.zuelke@bitextender.com>
CC: php-dev List <internals@lists.php.net>
References: <BAB5D597-0C47-43E8-B2E0-0DD6591F5CFF@bitextender.com> <67DEF003-A344-4BE6-9C23-6BB48935786F@bitextender.com>
In-Reply-To: <67DEF003-A344-4BE6-9C23-6BB48935786F@bitextender.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: SOAP_MARSHAL_DATETIME (or: bug #44383)
From: dmitry@zend.com (Dmitry Stogov)

Hi David,

I took only a quick look, but I like the patch.
In case it doesn't break any tests, it should be committed at least into
HEAD. I agree to commit it into 5.3 too, but RMs take the final decision.

The only thing I didn't understood - why win32/php_stdint.h is needed.

Thanks. Dmitry.

David Z=FClke wrote:
> *bump*
>=20
> Dmitry, did you have a chance to review this patch yet?
>=20
> - David
>=20
>=20
> On 22.06.2009, at 15:21, David Z=FClke wrote:
>=20
>> Hi folks,
>>
>> attached is a patch (with the respective test cases) that implements
>> DateTime marshalling from and to xsd:dateTime in ext/soap as requested
>> in http://bugs.php.net/44383
>>
>> Right now, it is implemented for xsd:date, xsd:time and xsd:dateTime,
>> but not for other types defined in W3C XML Schema such as gDayMonth; I
>> don't really think it makes sense mapping from and to DateTimes in
>> this case (from DateTime to gDayMonth would work, but the other way
>> round would prove rather difficult).
>>
>> Some notes about this patch:
>> - it conforms strictly to the XML Schema specification by only
>> producing canonical representations of values when generating
>> xsd:dateTime and xsd:time values. Specifically:
>> - it will not generate trailing zeroes on microseconds (in other
>> words, it simply generates a fractional second part as mandated by the
>> specification), but it will accept such values
>> - UTC is always used as the timezone (one of the tests in
>> ext/date/tests that mirrors SBR1-echoDate from
>> http://www.w3.org/TR/2007/REC-soap12-testcollection-20070427/#SBR1-ech=
oDate currently
>> does this wrong), but it will accept any timezone
>> - xsd:time produces current date when generating a DateTime object
>> - xsd:date is relatively straightfoward as well:
>> - produces "00:00:00" as the time when creating a DateTime object
>> - accepts any time when parsing
>> - also supports timezones
>> - as a side effect of the patch, microseconds are now supported in
>> time values (for xsd:time and xsd:dateTime), hence the removed comment
>> in to_xml_time
>>
>> The tests have several permutations, but all but one is commented out
>> each. The test_schema() function does some odd (but understandable)
>> stunts with output buffering and global variables that make it
>> impossible to test more than one case at a time. We didn't want to
>> produce a million test files for the several variants; is there a
>> nicer way to test this properly?
>>
>> This feature is enabled by a SoapClient "feature" called
>> SOAP_MARSHAL_DATETIME. I think this is a reasonable choice.
>>
>> Greetings,
>>
>> David
>>
>> <schema089.phpt><soap_marshal_datatype.diff.txt><schema087.phpt><schem=
a088.phpt><schema086.phpt><schema090.phpt><schema091.phpt>
>>
>=20