Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:45045 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26805 invoked from network); 20 Jul 2009 11:00:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jul 2009 11:00:29 -0000 Received: from [127.0.0.1] ([127.0.0.1:15405]) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ECSTREAM id F3/0B-02180-C4E446A4 for ; Mon, 20 Jul 2009 07:00:29 -0400 Authentication-Results: pb1.pair.com header.from=jani.taskinen@iki.fi; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@iki.fi; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain iki.fi from 204.13.248.71 cause and error) X-PHP-List-Original-Sender: jani.taskinen@iki.fi X-Host-Fingerprint: 204.13.248.71 mho-01-ewr.mailhop.org Received: from [204.13.248.71] ([204.13.248.71:64090] helo=mho-01-ewr.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A5/7A-02180-A6A446A4 for ; Mon, 20 Jul 2009 06:43:54 -0400 Received: from a88-112-30-186.elisa-laajakaista.fi ([88.112.30.186] helo=localhost.localdomain) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.68) (envelope-from ) id 1MSqLX-0003Na-Sm; Mon, 20 Jul 2009 10:43:52 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 88.112.30.186 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+lC35knozG0E8SweDB54l85c9SiLqHpU4= Message-ID: <4A644A66.2040706@iki.fi> Date: Mon, 20 Jul 2009 13:43:50 +0300 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Sriram Natarajan CC: PHP internals References: <4A616EFE.7090107@GMail.COM> <4A6189AF.6040001@sci.fi> <4A61F243.7040902@GMail.COM> In-Reply-To: <4A61F243.7040902@GMail.COM> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] PATCH for bug 48774 From: jani.taskinen@iki.fi (Jani Taskinen) On 07/18/2009 07:03 PM, Sriram Natarajan wrote: > Jani Taskinen wrote: >> Sriram Natarajan wrote: >>> Hi >>> I was looking into CR: >>> 48774(http://bugs.php.net/bug.php?id=48774&thanks=3) and was hoping >>> if some one can kindly review this patch. This patch does address the >>> SEGV issue reported in the bug. Can this be applied to PHP 5.3 and >>> PHP 5.2 as well ? >>> >> Fix your whitespace first. We use tabs only in .c files.. >> > Please find the updated patch below As you seem to have your own svn account, I guess you can commit it yourself now? :) --Jani