Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44972 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26994 invoked from network); 15 Jul 2009 07:46:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jul 2009 07:46:49 -0000 Authentication-Results: pb1.pair.com header.from=indeyets@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=indeyets@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.228 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: indeyets@gmail.com X-Host-Fingerprint: 209.85.219.228 mail-ew0-f228.google.com Received: from [209.85.219.228] ([209.85.219.228:36255] helo=mail-ew0-f228.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2C/FC-57267-8698D5A4 for ; Wed, 15 Jul 2009 03:46:48 -0400 Received: by ewy28 with SMTP id 28so3087499ewy.23 for ; Wed, 15 Jul 2009 00:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=PEYkkuk6tCo/s8nCqFuKeD7jGElzHEJebEUzlzJc19U=; b=jSxRSj4eyTJjyNnTrQzmgQI712P6nCgpCog3eq12JYrGmrEgUCxxK1bF5Xqu6hTHkv 1Dn3PMz5ljAz+4tq3oSURiVB5G7P4mHWRbyljZ0dwWIR+Jxdaaztg5+RQCWjRzxFTRNV /ZQ23Ewy9MB4tLsO/zYtGL1G24yILfB+rkzXE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=dhvgliGw5lJH0v3kiM8N/StDpi1B/zo4A3KnxaoBj2L3YcM6ZxZF/FwcasaLJ8H8dW PqgkVTpOMqtTUr8OM+fTMtW64EgQqLwF5ha2ju19+NvErOrbaR7nBpD2a7kGn2SR8tXz jnw5QKHIbuRjPJ1q/ZN2dCKcp3KhgjGox3KvE= MIME-Version: 1.0 Received: by 10.210.130.13 with SMTP id c13mr5565328ebd.92.1247644005320; Wed, 15 Jul 2009 00:46:45 -0700 (PDT) In-Reply-To: References: Date: Wed, 15 Jul 2009 11:46:45 +0400 Message-ID: To: David Soria Parra Cc: internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP From: indeyets@gmail.com (Alexey Zakhlestin) On Wed, Jul 15, 2009 at 11:16 AM, David Soria Parra wrote: > On 2009-07-15, Alexey Zakhlestin wrote: >> The patch is simple and clean. Just 2 notices.. >> 1) Zend/zend_dtrace.h file is generated. Are you sure it should be the >> part of patch? > > The generated dtrace header on Solaris and MacOS are different. > Therefore people have to generate them during configure and then cannot > copy&paste sources to another machine and build, that's why the provided > zend_dtrace.h includes both variants of the header file and is included > in the patch. The problem is, that if we update Zend/zend_dtrace.d, this header file will need to be regenerated. So, there is a need for a corresponding procedure. -- Alexey Zakhlestin http://www.milkfarmsoft.com/