Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44971 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14611 invoked from network); 15 Jul 2009 07:16:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jul 2009 07:16:19 -0000 X-Host-Fingerprint: 87.118.104.77 ns.experimentalworks.net Date: Wed, 15 Jul 2009 03:16:18 -0400 Received: from [87.118.104.77] ([87.118.104.77:5617] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 28/3A-57267-2428D5A4 for ; Wed, 15 Jul 2009 03:16:18 -0400 To: internals@lists.php.net References: Message-ID: User-Agent: slrn/0.9.8.1pl1 (Debian) X-Posted-By: 87.118.104.77 Subject: Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP From: david.soriaparra@sun.com (David Soria Parra) On 2009-07-15, Alexey Zakhlestin wrote: > The patch is simple and clean. Just 2 notices.. > 1) Zend/zend_dtrace.h file is generated. Are you sure it should be the > part of patch? The generated dtrace header on Solaris and MacOS are different. Therefore people have to generate them during configure and then cannot copy&paste sources to another machine and build, that's why the provided zend_dtrace.h includes both variants of the header file and is included in the patch.