Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44970
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.228 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=gRGYavxUEYB5L/Wh7PFlperrUys1HVcg1woVsi3dkk4KLq+Fjo+J2Ci/p1k/VGFkBb
         zusqxwePQwc869qDaTmuOke67S4BBBJX+KHQwQKFs4PjjxDkMl7AQ6IU6TQ2bTUVz+/w
         4D6yxB6VPSOvigNLxuCZztEAXtv/hg74wR1JQ=
MIME-Version: 1.0
In-Reply-To: <slrnh5pu9b.dhc.sn_@experimentalworks.net>
References: <slrnh5pu9b.dhc.sn_@experimentalworks.net>
Date: Wed, 15 Jul 2009 10:01:54 +0400
Message-ID: <cd5680a20907142301l5bb2d73bm679eb9e92cb5d1f1@mail.gmail.com>
To: David Soria Parra <david.soriaparra@sun.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP
From: indeyets@gmail.com (Alexey Zakhlestin)

On Wed, Jul 15, 2009 at 1:31 AM, David Soria
Parra<david.soriaparra@sun.com> wrote:
> Hi List,
>
> in the last months I worked on adding DTrace probes to PHP and would
> like to start a discussion about the RFC and patch against trunk
> that can be found at:
>
> =C2=A0http://wiki.php.net/rfc/dtrace
>
> DTrace is a dynamic tracing framework for Solaris, OpenSolaris, Mac OSX
> and FreeBSD that can be used to trace running applications on a system
> based on instrumentation points in the kernel and the application.

Also, there is an ongoing effort of adding DTrace support to linux.
Blog of the author: http://www.crisp.demon.co.uk/blog/index.html

> The patch aims to include static probes into PHP which will better reflec=
t
> PHP execution from a user persective. At the moment PHP can only be
> traced with deep knowledge of the executor and it's functions.
>
> The patch is based on recent trunk and can be found at:
>
> =C2=A0http://patches.experimentalworks.net/dtrace.patch
>
> In the current state the patch introduces a wrapper for the current
> executor to fire function-entry probes. It was mentioned that it might
> be useful to not use an own funciton for that. As I want to make things
> cleaner for the current state of review, I decided to use a separate
> function.
>
> The patch was tested on Mac OS 10.5, Solaris 10 and OpenSolaris 2009.06.

The patch is simple and clean. Just 2 notices..
1) Zend/zend_dtrace.h file is generated. Are you sure it should be the
part of patch?
2) Probes would benefit from having more details (exception-messages,
function-arguments, etc.)

Other than that, I am all for including this in trunk. Earlier we have
it =E2=80=94 earlier we can start tuning it :)

--=20
Alexey Zakhlestin
http://www.milkfarmsoft.com/