Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44804
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain prohost.org from 74.125.92.26 cause and error)
Cc: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@php.net>,
 PHP internals <internals@lists.php.net>
Message-ID: <C7F0588B-3BF7-49BA-8469-A0CDE0635955@prohost.org>
To: Paul Biggar <paul.biggar@gmail.com>
In-Reply-To: <af54caaf0907071607r68b9e790ofa717ad7f8fd70d0@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Apple Message framework v935.3)
Date: Tue, 7 Jul 2009 20:13:46 -0400
References: <2D0F5226-EBCA-4B45-BF01-8ED1C643976C@prohost.org>  <1247006344.3760.164.camel@goldfinger.johannes.nop> <af54caaf0907071607r68b9e790ofa717ad7f8fd70d0@mail.gmail.com>
Subject: Re: [PHP-DEV] Type hinting/casting request for vote
From: ilia@prohost.org (Ilia Alshanetsky)

All of the identified issues can be resolved and none of them =20
represent a major challenge to address. However, if there is no =20
consensus to put this in the near future (which at this point is 5.3), =20=

I have hard time justifying spending further time on this. The =20
original patch that was posted, that did break BC was far simpler and =20=

featureless, the changes since (which took a fair amount of work) were =20=

specifically made to address some of the main concerns that were on =20
the list. I feel what is on the table right now is pretty close to =20
what a final product could be, to have a vote on it. If decision is =20
made to proceed within a practical release schedule, then suffice to =20
say that I'd be more then happy to put further time to address the =20
minor issues indicated.


On 7-Jul-09, at 7:07 PM, Paul Biggar wrote:

> 2009/7/7 Johannes Schl=FCter <johannes@php.net>:
>> On Mon, 2009-07-06 at 20:52 -0400, Ilia Alshanetsky wrote:
>>> Last week or so there was a fairly detailed discussion on the
>>> internals list regarding type hinting based on my original patch.
>
>
>> Having an "old" 5.3 extension with a typehint expecting an array
>> arg_info.array_type_hint will be set to 1.
>> The newly compiled engine with this patch will then do
>>
>> +               /* existing type already matches the hint or forced =20=

>> type */
>> +               if (Z_TYPE_P(arg) =3D=3D =
cur_arg_info->array_type_hint =20
>> || Z_TYPE_P(arg) =3D=3D (cur_arg_info->array_type_hint ^ (1<<7))) {
>>
>> as it's main type check, but Z_TYPE_P(arg) will be IS_ARRAY (5) which
>> doesn't match the 1 provided by the old extension, other checks in =20=

>> there
>> will fail too, so the valid param will be rejected whereas an integer
>> (IS_LONG 1) will be accepted where the extension expects an array.
>
> I raised this in my review, to which Ilia replied "It should be fine"
> (http://news.php.net/php.internals/44707). I would not have thought it
> would be fine.
>
> I had been thinking that Ilia would have to hack it to make 1 mean
> array in this case, which would be ugly, but workable. Based on the
> arguments in this thread, I believe it shouldn't go into 5.3 at all.
> Are we allowed break the ABI for 5.4 (I would think so, but amn't
> sure).
>
>
>
> Overall, I'm very disappointed with the way this has been conducted.
> When reviews were posted they are not replied to (Stas posted
> http://news.php.net/php.internals/44710, I posted
> http://news.php.net/php.internals/44706, and I dont see any replies
> except a cursory response to mine). Furthermore:
>  - the RFC process has been wilfully ignored (despite multiple =20
> requests)
>  - a vote was asked for when Lukas was still trying to discuss his =20
> proposal
>  - the vote was take it or leave it
>  - there has been a general attitude of "throwing the toys out of =20
> the pram"
>
>
> I am mostly for the patch, and I 100% support the idea. However, I
> feel I have to vote against it, and urge others to do the same, until
> the entire mess is rectified.
>
> Ilia, I respect the work you have put into this, but I would ask you
> to withdraw the patch and the vote until these things have been sorted
> out.
>
>
> -1
>
> Thanks,
> Paul
>
>
>
> --=20
> Paul Biggar
> paul.biggar@gmail.com