Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:44785 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26995 invoked from network); 7 Jul 2009 18:27:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Jul 2009 18:27:27 -0000 Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 204.13.248.71 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 204.13.248.71 mho-01-ewr.mailhop.org Received: from [204.13.248.71] ([204.13.248.71:55766] helo=mho-01-ewr.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D9/B6-17523-D83935A4 for ; Tue, 07 Jul 2009 14:27:26 -0400 Received: from cs181029147.pp.htv.fi ([82.181.29.147] helo=[127.0.0.1]) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1MOFNz-000JvK-Gx; Tue, 07 Jul 2009 18:27:23 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 82.181.29.147 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19vA3r2n0CRAu9eFfNAP64zutqsbstuWNU= Message-ID: <4A539391.6040700@sci.fi> Date: Tue, 07 Jul 2009 21:27:29 +0300 Reply-To: jani.taskinen@iki.fi User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: John Mertic CC: internals@lists.php.net References: <2a9adcf0810221003i70f37558ob5777b5603865cdf@mail.gmail.com> <1224696974.17075.1.camel@localhost> <2a9adcf0810221135h1e6ed4ecub55318cfb26b3e7e@mail.gmail.com> <370571A4-8A89-412C-A8CD-1D7439C761F1@prohost.org> <2a9adcf0810221428v29a612a1i5425cbce95acf4a@mail.gmail.com> <2a9adcf0811060552u7486262bua509bde4d9807ff9@mail.gmail.com> <2a9adcf0907071046i5cec8c63gec0a1888fa3151ed@mail.gmail.com> In-Reply-To: <2a9adcf0907071046i5cec8c63gec0a1888fa3151ed@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Bug #46367 - fputcsv does not add the correct newline character on Windows From: jani.taskinen@sci.fi (Jani Taskinen) John Mertic kirjoitti: > Hi All, > > Bringing this one back once more; let me know what everyone thinks > about it. If it's safe to commit than if someone could ( or give me > the karma to do so ) that would be great. If not, let me know what > should be done about it instead. Is \r\n okay on Mac? Is \r okay on Windows? etc. Short: Shouldn't this be always \r\n? Or better yet, default to \r\n and add extra option for fputcsv with which you can set it to anything you like.. :) --Jani