Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:44710
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender)
Message-ID: <4A4FC5C6.1010201@zend.com>
Date: Sat, 04 Jul 2009 14:12:38 -0700
Organization: Zend Technologies
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
CC: Ilia Alshanetsky <ilia@prohost.org>, 
 PHP internals <internals@lists.php.net>
References: <FC14FAFE-6785-4067-9B49-9FC14F159C52@prohost.org> <af54caaf0907041149m69fe22edh3a66fc9f1bf19f0f@mail.gmail.com>
In-Reply-To: <af54caaf0907041149m69fe22edh3a66fc9f1bf19f0f@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC: Type hinting revisited for PHP 5.3
From: stas@zend.com (Stanislav Malyshev)

Hi!

> RE your second patch, from http://ilia.ws/patch/type_hint_53_v2.txt

Some notes on this patch:

- I still think the matter of interfaces and inheritance should be dealt 
with (and just comparing hints is not enough, it should be full 
LSP-compliant check).

- It looks like you can't have class named "string" anymore, or at least 
you can't use it in typehints (you can in 5.3). Same with all other type 
names there.

- I see no reflection method that allows to get the type of the 
parameter (as opposed to checking if the parameter belongs to a certain 
type)

- The patch contains the check that the constant for an optional 
parameter is not an object. AFAIK you can't have constant with object 
type in PHP. Which also means initializer for any object type can only 
be null.

- There seems to be no way to have default value with IS_NUMERIC 
typecheck since the check
Z_TYPE(initialization->u.constant) != class_type->u.constant.type
will always fail for IS_NUMERIC - there's no zval carrying type 
IS_NUMERIC. Same for IS_SCALAR.

- Also, I'm not sure what would happen there if I have:
function foo(numeric $param = CONSTANT)
and the value of CONSTANT may be not known in the compile-time. Looks 
like right now it would just fail since CONSTANT has IS_CONSTANT type.
That would be confusing if you couldn't use constants for default values 
with typehints.

- Shuouldn't this:
if (Z_TYPE_P(arg) == cur_arg_info->array_type_hint || Z_TYPE_P(arg) == 
(cur_arg_info->array_type_hint ^ (1<<7))) {
be this:
if (Z_TYPE_P(arg) == (cur_arg_info->array_type_hint & 0x7F)) {
this would be one check instead of two, and the type of argument zval 
can't really be FORCE_*, can it?

- Are you sure with FORCE_* argument converting operation shouldn't be 
convert_to_*_ex?
-- 
Stanislav Malyshev, Zend Software Architect
stas@zend.com   http://www.zend.com/
(408)253-8829   MSN: stas@zend.com